From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: esh-proc test failures Date: Tue, 23 Aug 2022 19:22:45 +0300 Message-ID: <83v8qj6iay.fsf@gnu.org> References: <166036758418.2203.8730240669199078524@vcs2.savannah.gnu.org> <20220813051305.6667BC09BFE@vcs2.savannah.gnu.org> <87o7wmg0nx.fsf_-_@gnus.org> <30a7e3aa-ad52-325f-4fcd-528aade4a339@gmail.com> <838rng9kes.fsf@gnu.org> <837d2zae3m.fsf@gnu.org> <83v8qj8a2y.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 23 18:24:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQWhM-0006az-Ev for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 18:24:16 +0200 Original-Received: from localhost ([::1]:57168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQWhK-0008Mp-QB for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Aug 2022 12:24:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQWfo-0005fF-GV for emacs-devel@gnu.org; Tue, 23 Aug 2022 12:22:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQWfo-0001Cg-3o; Tue, 23 Aug 2022 12:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZJ/Dm5Xca/h2xSOJZ7MAL1/QpI+sJywmV0t7GNRkdbA=; b=Axb2Ij/gkusJ 0vSQXgCM7Se3E4WHqjKwtY6QS50RpxaBdq8fZ1sVcoyW4TEPPeOGKDoSpEOpBFEVUjw46o8NhDQGM 94TIOuqXDUmj0hEq0TMt+LoH4SfTAxyegszdq98vlizA09d7suQbR7/ZpVNFblXQiKIdzPNszAiee 9M/TvOcfxiEGPHKFgn2qIEz8sgZRiz90vpOwy2LrT1iV/QoY0lVMvOUrK53y6ZfvrZIbDgoDbVcnj ZmylmeYPqAKLAkhON5oTxvl5SFyHlKSuworc9q8EFRnhsX1zXX8HoGh3qeXjSh9yZUymnlW6cHgAa AffqhysrIv19AChP+Xz4sQ==; Original-Received: from [87.69.77.57] (port=2227 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQWfn-0003mb-J5; Tue, 23 Aug 2022 12:22:39 -0400 In-Reply-To: (message from Jim Porter on Tue, 23 Aug 2022 08:57:37 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293903 Archived-At: > Cc: larsi@gnus.org, emacs-devel@gnu.org > From: Jim Porter > Date: Tue, 23 Aug 2022 08:57:37 -0700 > > > I don't think I follow. When the write fails, we get an error and > > propagate it all the way up to the caller. > > If we signal an error in a process filter, does Emacs inform the process > that wrote that data of the error? My tests showed that it didn't, but > maybe I was doing something wrong. Why are you talking about the process filter? Does that filter call process-send-string to write to the next process in the pipe? If so, it should inform Emacs about any errors in writing. > The goal here is just to tell a process that the thing it's writing to > is gone, and that it should give up. That cannot happen, because Eshell is in-between. Instead, it is Emacs (Eshell) that should see the error, and deliver a signal to the relevant process if needed.