From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making `eglot-server-programs' a custom variable? Date: Thu, 10 Nov 2022 13:23:44 +0200 Message-ID: <83v8nnqchr.fsf@gnu.org> References: <86fservpri.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arash@gnu.org, theophilusx@gmail.com, emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 12:24:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot5fL-0002G8-T1 for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 12:24:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot5ey-0002g2-C1; Thu, 10 Nov 2022 06:23:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5es-0002et-11 for emacs-devel@gnu.org; Thu, 10 Nov 2022 06:23:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5er-00082h-OQ; Thu, 10 Nov 2022 06:23:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dnDFWX90OtEp9bDG2RbQHKzNvW06TIOqypYB+ngj0XU=; b=rIq6Ez/qDjoohoonXIsz JvMg2g5F9vMyMKLS2XhwywtfOjFuTRW8njHEyu58HlXdP6pjV5ru+RydFsUXBLxdRVf0M8nDJeJid 0NUcLhMcAC5ohoqXyJe2KPfw/M1+6YXJqWLZKt/j8IkCUWXM5xSLCbdp1NstIvH2K3Wsr3cTt5TE5 rCTdMABnmtICdI55sJ0OZolnNZGPusclBmu9mI9srY53uRNfiXqc4yInHrTtmjmqmIjG9I28/Ha/p WrgOrXvoQSxCwuXMNlqTkv2GSggUMzVJlQADns/UZTcm9P+jU4ddaOD8SKEFYmHNy7yhR0HcfQ7gm Fod9CbWFpwqRKA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5eq-0003hr-1P; Thu, 10 Nov 2022 06:23:44 -0500 In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Thu, 10 Nov 2022 10:15:41 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299479 Archived-At: > From: João Távora > Date: Thu, 10 Nov 2022 10:15:41 +0000 > Cc: emacs-devel > > Arash, I think your suggestion of recommending `with-eval-after-load` > is pertinent and should be added to the manual. How about adding a command to add servers to the list instead? See below. > Eli, even though we provide a healthy dose of built-in server invocations > in that variable, we can't and shouldn't aim at being exhaustive. > > Eglot's manual is meant to be a go-to guide for knowing how to resolve > simple problems such as this one, which is very common. The problems > solved by eglot-workspace-configuration and other variables are also > very common. The manual should be reasonably self sufficient, not too > terse or relying on the user's knowledge. IMNSHO, it is not the mission of the Eglot manual to teach people with-eval-after-load and in general how to update lists that aren't autoloaded or preloaded. This is a slippery slope. > That said, I have no objection to converting eglot-server-programs into > a defcustom, if someone will commit to translating and maintaining all > the complex combination of options into "widget" form. I don't have the > time or inclination for this task, but maybe someone has. It is not a good idea to have a defcustom whose value should be such a complex data structure. If we think users will have to augment the value, it is better to add a command to do that, and in that command hide all the complexity and subtleties of the value.