From: Eli Zaretskii <eliz@gnu.org>
To: Shynur Xie <one.last.kiss@outlook.com>
Cc: mattiase@acm.org, emacs-devel@gnu.org, luangruo@yahoo.com
Subject: Re: Bug?
Date: Fri, 05 May 2023 07:41:14 +0300 [thread overview]
Message-ID: <83v8h7jsph.fsf@gnu.org> (raw)
In-Reply-To: <SA0PR04MB74330B14B6388199D0A73C0BD76D9@SA0PR04MB7433.namprd04.prod.outlook.com> (message from Shynur Xie on Thu, 4 May 2023 20:57:36 +0000)
> From: Shynur Xie <one.last.kiss@outlook.com>
> CC: "emacs-devel@gnu.org" <emacs-devel@gnu.org>, "luangruo@yahoo.com"
> <luangruo@yahoo.com>
> Date: Thu, 4 May 2023 20:57:36 +0000
> msip_labels:
>
> >> I also noticed that when the closing bracket is comprised of
> >> multiple characters, only the first character is high-lit using
> >> that face. For example, in shell-script-mode, when `esac` matches
> >> `case`, only the `c` in `case` is high-lit. Perhaps this new
> >> feature isn't quite finished yet.
> >
> > Shynur, could you please fix this deficiency?
>
> Patch is attached. To highlight the entire matched opening delimiter:
> (show-paren-mode)
> (setq blink-matching-paren-offscreen t
> show-paren-context-when-offscreen t)
Thanks, but I don't think I understand: didn't you tell that the
problem reported above is not a bug, but the expected and long-time
behavior of blink-matching-paren? If so, what exactly does this patch
fix?
> I also changed the function `blink-paren-open-paren-line-string':
> Originally, say here's a shell script
> case case
> ... <- many lines
> esac* <- cursor here
> both `blink-matching-open' and `show-paren-mode' emitted "case c";
> Now `show-paren-mode' instead emits "case case" if
> `show-paren-context-when-offscreen' is t.
This seems to be about show-paren-mode, not about
blink-matching-paren. Those are different, though related, features.
next prev parent reply other threads:[~2023-05-05 4:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <875y9aciir.fsf.ref@yahoo.com>
2023-05-03 1:26 ` Bug? Po Lu
2023-05-03 9:40 ` Bug? Mattias Engdegård
2023-05-03 10:12 ` Bug? Mattias Engdegård
2023-05-03 11:24 ` Bug? Shynur Xie
2023-05-03 12:27 ` Bug? Mattias Engdegård
2023-05-03 17:22 ` Bug? Juri Linkov
2023-05-03 11:24 ` Bug? Eli Zaretskii
2023-05-03 11:26 ` Bug? Shynur Xie
2023-05-04 8:35 ` Bug? Shynur Xie
2023-05-04 20:57 ` Bug? Shynur Xie
2023-05-05 4:41 ` Eli Zaretskii [this message]
2023-05-05 16:18 ` Bug? Shynur Xie
2023-05-06 10:44 ` Bug? Mattias Engdegård
2023-05-06 14:58 ` Bug? Shynur Xie
2023-05-06 15:24 ` Bug? Eli Zaretskii
2023-05-07 11:08 ` Bug? Mattias Engdegård
2023-05-07 12:05 ` Bug? Po Lu
2023-05-07 12:17 ` Bug? Eli Zaretskii
2023-05-07 12:54 ` Bug? Po Lu
2023-05-07 13:36 ` Bug? Shynur Xie
2023-05-07 13:51 ` Bug? Mattias Engdegård
2023-05-07 14:42 ` Bug? Shynur Xie
2023-05-07 15:06 ` Bug? Eli Zaretskii
2023-05-03 11:23 ` Bug? Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8h7jsph.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=mattiase@acm.org \
--cc=one.last.kiss@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).