From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Org mode update breaking build? Date: Tue, 09 May 2023 19:47:20 +0300 Message-ID: <83v8h1a1uv.fsf@gnu.org> References: <00b52cc1-b0ac-a0c0-c91d-33a7213e9881@web.de> <83v8h9l5cw.fsf@gnu.org> <87lehx4g6i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5936"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: sds@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 09 18:46:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwQUC-0001Mk-5E for ged-emacs-devel@m.gmane-mx.org; Tue, 09 May 2023 18:46:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwQTi-0004wq-0a; Tue, 09 May 2023 12:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQTh-0004w7-AD for emacs-devel@gnu.org; Tue, 09 May 2023 12:46:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQTg-0002CE-QI; Tue, 09 May 2023 12:46:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5EVK/Jk7yE1F9zLbxRz6EmQFPN8iz0uat6IKwp0ah/0=; b=U2ffrtEZkSQ62ufh445N wpHpG3kQiozsFvCMYUvxY0lbPI+nnyXymX0IjJgmsobcMPO3v4N2w29xjTdWsqHGrmEnTpp0KHi7D eWUVIrcwvZHdJ5FS1duYAp8rMLxR1oIJn7ine0daBb0UUWIs7jl7OrQ6UjoerIcEdzpX9hnKeHakz Y4/M1/vjjcuv0fHN312lA9dkJP2cQ3NnsAXoZCJLMY105k86RfV/l5xSJF4UDHP32pds8+1FDtD7Y d1ryw5KYmaUnYUYMe5rs2aoL/qCYjV8RTeo+bf+aJWTkF+ZphabY0VVDOXV1EpbU4UKzTtxREUP7b 5irnMGfiVJBL4g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQTg-0003JR-8u; Tue, 09 May 2023 12:46:16 -0400 In-Reply-To: <87lehx4g6i.fsf@gnu.org> (message from Sam Steingold on Tue, 09 May 2023 12:34:29 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306011 Archived-At: > From: Sam Steingold > Date: Tue, 09 May 2023 12:34:29 -0400 > > > * Eli Zaretskii [2023-05-03 19:58:07 +0300]: > > > > We already fixed that, but only on master. So you don't need to > > convince anyone that this needed fixing. We are convinced. > > I built from git master and did not get any errors. > However, when I visited an org-mode file, I got this: > > --8<---------------cut here---------------start------------->8--- > Debugger entered--Lisp error: (error "Org version mismatch. Make sure that correct ‘load-path’ is set early in init.el") > error("Org version mismatch. Make sure that correct `load-path' is set early in init.el") > byte-code(...) > require(org-keys) > byte-code(...) > org-mode() > set-auto-mode-0(org-mode nil) > set-auto-mode() > normal-mode(t) > after-find-file(nil t) > find-file-noselect-1(# "~/xxx.txt" nil nil "~/xxx.txt" (1180547 66307)) > find-file-noselect("~/xxx.txt" nil nil t) > find-file("~/xxx.txt" t) > funcall-interactively(find-file "~/xxx.txt" t) > command-execute(find-file) > --8<---------------cut here---------------end--------------->8--- > > (along with the usual long but worthless instructions) That's expected when there's an incompatible change. It can also happen with other packages, not just with Org. It's nothing new. > Basically, an apparently successful build no longer guarantees that the > resulting Emacs will be working. That was never guaranteed. Not just when Org changed. > It would seem that if the build process can detect this "Org version > mismatch", it should just `rm -f lisp/org/*.elc` and restart (remembering > that it tried this hack to avoid an infinite loop if it does not work). Feel free to propose how to detect this, and then restart, without disrupting the whole build. We are not just compiling Org, we compile hundreds of Lisp files, so whatever you propose should be consistent with how the normal build proceeds, including its support for high parallelism. If a better solution will be found, we will surely embrace it.