From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Mon, 07 Aug 2023 15:03:18 +0300 Message-ID: <83v8drnjp5.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <83h6pcrbe9.fsf@gnu.org> <11660747.27k8W16iEi@nimes> <87a5v45pmj.fsf@yahoo.com> <15527b3e-9334-c03d-e0a5-0828381a0071@cs.ucla.edu> <838raooy85.fsf@gnu.org> <875y5r4tfa.fsf@yahoo.com> <871qgf4qxs.fsf@yahoo.com> <83y1innlpe.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 07 14:04:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSyxv-0008Yq-OD for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Aug 2023 14:04:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSyxB-0001T5-RZ; Mon, 07 Aug 2023 08:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSywv-0001M7-3P for emacs-devel@gnu.org; Mon, 07 Aug 2023 08:03:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSywt-0001XA-Fp; Mon, 07 Aug 2023 08:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GthEfn/GHZakm5X0SCJ0tqwlM3ZEKMA8QM4rl6qSkB0=; b=gUPe3aXc0kRi dC/u8gBbya59GhP+aREuzO0LMHozVL8Aq1y48+BedE5nyXRxyL5OcBO36OFd7cFTORJwV6LkNkYmM dXlGjjLxb3GI7vbjEEDrIuwcBMR0eKSrgEk7lPImMc00HHTRSTKciRZmWD9iNnPEtG67Pr9YmjzPm SdIVwkpqKYtQStSKTs0uEIwbwnd62zYHw4iJyWfXioee7MTL5wmc+IS9LWBUhxagxL4wTSHJzvlo1 Slf7UEARemRZTxc63N2kkS2J6k2XNBxi7htWAGx/inw+QtQStQ14Rsz55+RmmZHA8COWLYy4r5xFk nyTT/EbeahIve1OhjaZkBQ==; In-Reply-To: <83y1innlpe.fsf@gnu.org> (message from Eli Zaretskii on Mon, 07 Aug 2023 14:19:57 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308410 Archived-At: > Date: Mon, 07 Aug 2023 14:19:57 +0300 > From: Eli Zaretskii > Cc: eggert@cs.ucla.edu, angelo.g0@libero.it, emacs-devel@gnu.org, > bruno@clisp.org > > Thanks. It looks like nt/gnulib-cfg.mk still names modules that were > eventually removed? Could you please audit the modules added to > gnulib-cfg.mk and remove the lines that are no longer needed on > master? Also, it looks like neither ENABLE_CHECKING nor GLYPH_DEBUG are being defined in src/config.h in the non-Android builds, although I passed the --enable-checking-'yes,glyphs' option to the configure script. This has something to do with this snippet of configure.ac: AS_IF([test "x$XCONFIGURE" = "xandroid" \ && test "x$android_enable_checking" = "xyes"], [ac_enable_checking=yes]) # There is little point in enabling checking in the build machine if # cross-compiling for Android. AS_IF([test -z "$with_android" || test -n "$XCONFIGURE"],[ if test x$ac_enable_checking != x ; then AC_DEFINE([ENABLE_CHECKING], [1], [Define to 1 if expensive run-time data type and consistency checks are enabled.]) fi It generates the following code in configure: # This environment variable is used to signal that checking should be # enabled on Android. When that happens, simply enable checking for # the cross-compiled Android binary. if test "x$XCONFIGURE" = "xandroid" \ && test "x$android_enable_checking" = "xyes"; then : <<<<<<<<<<<< ac_enable_checking=yes fi # There is little point in enabling checking in the build machine if # cross-compiling for Android. if test -z "$with_android" || test -n "$XCONFIGURE"; then : <<<<<<<<<<<< if test x$ac_enable_checking != x ; then $as_echo "#define ENABLE_CHECKING 1" >>confdefs.h fi and I believe that those colons ':' after 'then' are the culprit. But my Autoconf-fu is not strong enough to see what has to be done to fix this.