From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Adding with-editor to Emacs? Date: Sat, 02 Sep 2023 21:57:19 +0300 Message-ID: <83v8cs8kts.fsf@gnu.org> References: <85msy98sni.fsf@elpa.gnu.org> <87r0nidkmt.fsf@bernoul.li> <83bkelc1p1.fsf@gnu.org> <87fs3xwzxm.fsf@bernoul.li> <837cp9bur7.fsf@gnu.org> <87a5u5wskw.fsf@bernoul.li> <8334zxayhx.fsf@gnu.org> <871qfgbg13.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 02 20:58:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcVpK-00090U-MD for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Sep 2023 20:58:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcVoV-0008Pa-Ht; Sat, 02 Sep 2023 14:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcVoT-0008PE-3N for emacs-devel@gnu.org; Sat, 02 Sep 2023 14:57:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcVoR-0005c8-NK; Sat, 02 Sep 2023 14:57:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PJBJrJ3TXI7nZJ/nVUMAKalS19DTcui/QQo7zemECh4=; b=X0pBHgBPpRrB QogtyByJBEGGwxJ8Bvy2bObSLSUqIOP2P1NZUGRhI3UgF/Opn4vE95lxOj7nvjfU696vKj0ZnGXjp 0g/lKzWd0L+oyfd5P0nto4COPqM9TWKRlVmGczxpazo5+gSUNEZi5nv2gSij+7KhkYtBNPrVVGc/L Hh0zorrkEriOfoVfXSpXWXYMMPKTmpenUPinssDS4o9wMJ6tSQNViJSGaeKOHuv4MnSzlwTOhY/aa Le4RcKlDdVBqo6muAmkgbf131Z5g40yjctr2DFpRBdXwpEW0lGfJJlP6hYgJ3HE0Lm2W7CU8is8bp K7SaFqh+Uv+2B8PSENEU/g==; In-Reply-To: <871qfgbg13.fsf@bernoul.li> (message from Jonas Bernoulli on Sat, 02 Sep 2023 20:12:40 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309903 Archived-At: > From: Jonas Bernoulli > Cc: stefankangas@gmail.com, emacs-devel@gnu.org, rms@gnu.org > Date: Sat, 02 Sep 2023 20:12:40 +0200 > > > Then I guess you should describe all those atrocities in detail, so > > that we could perhaps devise ways of handling it. > > I do not have a list of those atrocities and I do not have the bandwidth > and motivation to compile that in the next few months. I have code that > deals with it though (with-editor-locate-emacsclient and the functions > it uses). Using git to trace the history of that code, would give you > commits with explanations and/or links to places were the issues that > are being addressed were described. It's not that easy: AFAIU, with-editor was part of Magit, and was separated into a repository of its own not very long ago. And the answers to my questions seem to be before the split. I also looked at the present code and found it to have quite a few non-trivial parts whose purpose I couldn't easily explain or guess, and which are not explained in the comments, either. So, if you have no time or motivation to describe the problems you tried to solve with that code, I guess someone else will need to find out and describe the problems in a way that we could then consider for inclusion. I cannot myself afford digging through the Magit's Git repository to find the description of these problems, sorry. Or maybe Richard already knows the answers, since he thought this should be added to Emacs.