From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Permanently fix org versioning breakage during builds? Date: Sun, 24 Dec 2023 20:32:00 +0200 Message-ID: <83v88nbgf3.fsf@gnu.org> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87y1djc1c9.fsf@localhost> <87zfxzdbna.fsf@yahoo.com> <87plyv7oii.fsf@localhost> <8734vr4prv.fsf@localhost> <835y0nd4ut.fsf@gnu.org> <87zfxz35b4.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, luangruo@yahoo.com, raman@google.com, joaotavora@gmail.com, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 24 19:32:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHTHW-0005GG-Eg for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Dec 2023 19:32:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHTGj-0006qo-GC; Sun, 24 Dec 2023 13:32:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTGi-0006qU-3L for emacs-devel@gnu.org; Sun, 24 Dec 2023 13:32:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTGg-00039I-3l; Sun, 24 Dec 2023 13:32:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iI308BSZt0EGgGc7Ui6KXsoKd/9tAsYjNNEwVtu19pA=; b=ChQ+Fch0BNML 7aj76ZXrKM90m0a6IbALx6CWve/iLQDUZVPPiGqfwEtOG5cqW+weTmBAwVsh61Um04/mpbPHNZ/KO xBEjzJw5d0vN4Z2yJvMlmJr0hE22CqOLnZ2TMIrAgfdS0TlEKOm5FoBzLrCd+6jO7pcMcelgjnHq8 mPnotTyg5HelvOOsCPUdxlBdwz+RKAuYIWScA1jKWqC2zVRq97L1CEl0HQu/YLT3hDXcH6C2xcYdE Q5SzS6GtFT9kNgRCfaiAXRPZG/odYb2xxckMgiBH4v0P+9vJhyLuCDUYg7K0gZFh0GTyq06/8TRmW YM9hC4qInS97Snp/lwF7RQ==; In-Reply-To: <87zfxz35b4.fsf@localhost> (message from Ihor Radchenko on Sun, 24 Dec 2023 16:59:11 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314172 Archived-At: > From: Ihor Radchenko > Cc: stefankangas@gmail.com, luangruo@yahoo.com, raman@google.com, > joaotavora@gmail.com, emacs-devel@gnu.org > Date: Sun, 24 Dec 2023 16:59:11 +0000 > > Eli Zaretskii writes: > > > But such breakage happens at times anyway, when some macros change in > > incompatible ways and files that have the old versions of those macros > > compiled into them are not recompiled. It isn't anything new for > > people who regularly update from Git and rebuild Emacs. > > The main problem is that with org-assert-version, "from time to time" > becomes more frequent as the breakage is guaranteed every time a new > version of Org is installed into Emacs tree. If org-assert-version is the source of breakage, then that's not the breakage I was talking about. I was talking about breakage due to changes in macros that were the motivation for you to introduce org-assert-version in the first place. IOW, instead of _inducing_ a breakage via org-assert-version, you should let stuff break by itself, when an incompatible change is made in one of the macros which org-assert-version protects.