From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MS-Windows build broken in Fmake_network_process Date: Sat, 27 Mar 2010 10:42:07 +0300 Message-ID: <83tys2fbxs.fsf@gnu.org> References: <83634jglab.fsf@gnu.org> <831vf7ge57.fsf@gnu.org> <83y6hfeyzw.fsf@gnu.org> <83vdcig87f.fsf@gnu.org> <87k4sywpvv.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1269676186 32092 80.91.229.12 (27 Mar 2010 07:49:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Mar 2010 07:49:46 +0000 (UTC) Cc: eller.helmut@gmail.com, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 27 08:49:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NvQm4-0003Td-7U for ged-emacs-devel@m.gmane.org; Sat, 27 Mar 2010 08:49:40 +0100 Original-Received: from localhost ([127.0.0.1]:40325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvQm1-0004Zl-53 for ged-emacs-devel@m.gmane.org; Sat, 27 Mar 2010 03:49:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvQes-0003Ck-PY for emacs-devel@gnu.org; Sat, 27 Mar 2010 03:42:15 -0400 Original-Received: from [140.186.70.92] (port=44391 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvQeq-0003CG-Pr for emacs-devel@gnu.org; Sat, 27 Mar 2010 03:42:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvQel-00035D-Kf for emacs-devel@gnu.org; Sat, 27 Mar 2010 03:42:12 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:38741) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvQel-000357-C4 for emacs-devel@gnu.org; Sat, 27 Mar 2010 03:42:07 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KZX00500JZZ8100@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 27 Mar 2010 10:42:05 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.176.135]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KZX003HQK24UD40@a-mtaout22.012.net.il>; Sat, 27 Mar 2010 10:42:05 +0300 (IDT) In-reply-to: <87k4sywpvv.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122755 Archived-At: > From: Chong Yidong > Cc: Helmut Eller , emacs-devel@gnu.org > Date: Fri, 26 Mar 2010 20:48:52 -0400 > > Eli Zaretskii writes: > > > Solution for what? The previous code had no problems on Windows. The > > bug report that triggered the new code was deeply rooted in Posix > > behavior; the solution is Posix-centric code, and was never tested on > > Windows. Why should it be run on Windows, and what ``problem'' will > > that solve? > > I conditioned the patch out for WINDOWSNT, for now, to avoid breaking > the Windows build. Thank you, it now builds again. > However, could you investigate whether we could link in getsockopt in > the Windows build? Yes, we could (it just needs an additional -lws2 switch during linking), assuming Someone(TM) knows how to resolve the issue with incompatible pointers in the 4th arg (see my original report about the broken build). But what would this be good for, if we don't understand the effect the added code will have on Windows? > Although the original bug recipe in Bug#5173 does not look relevant > to Windows, Bug#5723 might be. I'm probably missing something, because the fix for Bug#5723 was applied to the Windows build as well, and I can see no issues with it. That fix was about not starting atimers around the call to `connect'. How is this relevant to `getsockopt'?