From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Sun, 13 Mar 2011 20:41:28 +0200 Message-ID: <83tyf6rhgn.fsf@gnu.org> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <83oc5ogp89.fsf@gnu.org> <87ipvuwslp.wl%claudio.bley@gmail.com> <87hbbc0zi6.wl%claudio.bley@gmail.com> <83oc5gsdwc.fsf@gnu.org> <87ei6bunxz.wl%claudio.bley@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1300041694 17626 80.91.229.12 (13 Mar 2011 18:41:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 13 Mar 2011 18:41:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: claudio.bley@gmail.com (Claudio Bley) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 13 19:41:30 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PyqEM-00066i-GD for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2011 19:41:30 +0100 Original-Received: from localhost ([127.0.0.1]:53286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyqEL-0003fh-Vo for ged-emacs-devel@m.gmane.org; Sun, 13 Mar 2011 14:41:30 -0400 Original-Received: from [140.186.70.92] (port=54287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyqEG-0003fC-PH for emacs-devel@gnu.org; Sun, 13 Mar 2011 14:41:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PyqEF-0003b7-96 for emacs-devel@gnu.org; Sun, 13 Mar 2011 14:41:24 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:34463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PyqEF-0003aj-0L for emacs-devel@gnu.org; Sun, 13 Mar 2011 14:41:23 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LI000I00E57P800@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sun, 13 Mar 2011 20:41:21 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.96.116]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LI000IUSEKWPA00@a-mtaout21.012.net.il>; Sun, 13 Mar 2011 20:41:21 +0200 (IST) In-reply-to: <87ei6bunxz.wl%claudio.bley@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137196 Archived-At: > From: claudio.bley@gmail.com (Claudio Bley) > Date: Sun, 13 Mar 2011 14:53:12 +0100 > > > If all you need is to produce EAGAIN when you have EWOULDBLOCK (the > > other mapping is already in set_errno), it hardly justifies a > > function. > > That's true, WSAEINTR already gets mapped. Must have missed that. So are we in agreement that a separate new function is not required? > > > > > > +static ssize_t > > > > > > +emacs_gnutls_pull(gnutls_transport_ptr_t p, void* buf, size_t sz) > > > > > > > > > > Can we move the Windows-specific functions to w32.c, and only call > > > > > them from gnutls.c? I think we want to keep the Windows-related code > > > > > outside w32*.c to the bare minimum. > > > > > > > > OK. > > > > > > Maybe the GnuTLS specific stuff should also be kept to the bare > > > minimum outside of gnutls.c? > > > > What stuff did you have in mind? > > All the GnuTLS related functions (even if Windows specific). That's not what we do in Emacs. OS-specific #define's are best kept to a minimum, the sole exception being sysdep.c. Otherwise, we try to keep code of non-Posix and niche platforms on their specific sources files. > > > Considering that these functions would have to be non-static in this > > > case to be accessible by gnutls.c. > > > > Sure, but I see no problem with that. > > I'm usually a bit reluctant to create public functions in a module > which only serve a special purpose in one single other module. Why? Emacs is a program, not a general-purpose library. Invading some unknown namespace should not be an issue.