From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/4] Refactor window-system configuration Date: Fri, 30 Dec 2011 11:44:10 +0200 Message-ID: <83ty4itmvp.fsf@gnu.org> References: <4b98eec4a5f68bfcd9233d5e7444de05873225b4.1325166472.git.dancol@dancol.org> <4EFCE9C4.8050908@dancol.org> <4EFCEE59.7030605@dancol.org> <834nwiv3qc.fsf@gnu.org> <4EFD7F34.3070607@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1325238263 25244 80.91.229.12 (30 Dec 2011 09:44:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2011 09:44:23 +0000 (UTC) Cc: dann@gnu.org, emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 30 10:44:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgZ0c-0001jf-74 for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2011 10:44:18 +0100 Original-Received: from localhost ([::1]:49845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgZ0b-0002hc-LF for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2011 04:44:17 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:38673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgZ0Y-0002hM-Ij for emacs-devel@gnu.org; Fri, 30 Dec 2011 04:44:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgZ0X-0008St-IJ for emacs-devel@gnu.org; Fri, 30 Dec 2011 04:44:14 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:40983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgZ0U-0008SY-TP; Fri, 30 Dec 2011 04:44:11 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LX000500G0ZA200@a-mtaout20.012.net.il>; Fri, 30 Dec 2011 11:44:09 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.18.76]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LX00044YGDKVF60@a-mtaout20.012.net.il>; Fri, 30 Dec 2011 11:44:09 +0200 (IST) In-reply-to: <4EFD7F34.3070607@dancol.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147043 Archived-At: > Date: Fri, 30 Dec 2011 01:07:00 -0800 > From: Daniel Colascione > CC: Dan Nicolaescu , emacs-devel@gnu.org > > > Daniel, please keep in mind that at least Windows users normally know > > very little about autoconf, and will have difficulty finding their way > > around the configure script and its products, and understanding how > > and where the value of that constant is computed. > > > > Who exactly do you imagine being confused by a including macro and under > what circumstances do you expect this confusion to arise? The confusion will happen when J.R. Hacker wants to know where and how the value of that macro is computed. > A quick glance at config.h will reveal what header is being included One must know to look in config.h in the first place. And even then, the issue of _how_ that macro is computed will still remain. > The only people who need to care about the configure machinery are > those who add window systems, and I hope these people would be > familiar with autoconf. There's another kind of people who might need to care: those who need to figure out why their build process does the wrong thing with a window system. Suppose your patches, when applied, break the native w32 build in some rare case, for example, because the wrong window system is being computed. > I'd really prefer not to have another big list of window systems in the > source. Why "another"? I understand that you would be moving those other places to a single header file.