From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MS-Windows build using Posix configury Date: Thu, 16 May 2013 09:00:51 +0300 Message-ID: <83txm34g6k.fsf@gnu.org> References: <83d2tu49lu.fsf@gnu.org> <834nezzzma.fsf@gnu.org> <8361z2psr1.fsf@gnu.org> <83zjweo5dh.fsf@gnu.org> <83sj25nym2.fsf@gnu.org> <837gjhnowi.fsf@gnu.org> <8338u4o39r.fsf@gnu.org> <83zjwbkmt2.fsf@gnu.org> <83wqrfkjvo.fsf@gnu.org> <838v3qebns.fsf@gnu.org> <83wqr9csah.fsf@gnu.org> <83wqr297da.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1368684088 21074 80.91.229.3 (16 May 2013 06:01:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 06:01:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 16 08:01:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcrFn-00073S-54 for ged-emacs-devel@m.gmane.org; Thu, 16 May 2013 08:01:27 +0200 Original-Received: from localhost ([::1]:60500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcrFm-0007a2-M4 for ged-emacs-devel@m.gmane.org; Thu, 16 May 2013 02:01:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcrFf-0007Zx-Cc for emacs-devel@gnu.org; Thu, 16 May 2013 02:01:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcrFa-0000AK-KP for emacs-devel@gnu.org; Thu, 16 May 2013 02:01:19 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:65469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcrFa-0000A9-CF for emacs-devel@gnu.org; Thu, 16 May 2013 02:01:14 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MMV00400NCJII00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 16 May 2013 09:00:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMV00481NDGEB50@a-mtaout22.012.net.il>; Thu, 16 May 2013 09:00:53 +0300 (IDT) In-reply-to: <83wqr297da.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159610 Archived-At: > Date: Mon, 13 May 2013 19:23:13 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > With this out of my way, I need to update the branch to handle the > changes in the configury committed lately to the trunk, to handle the > ACL portability. (I was actually hoping that something like this > would happen, because I want to see how much effort is needed to make > such adaptations.) Before I adapt to that change, I cannot merge my > branch onto the trunk, because the result will most probably fail to > compile. I hope to do that in a couple of days, and then I'll merge > and announce. > > Stay tuned, and thanks for encouragement. I'm almost done. Adapting to the new gnulib module was easy, which is really good news. There's one minor issue, though. qset-acl.c didn't compile, because it requires the acl_delete_def_file function: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I/d/gnu/bzr/emacs/msys-build/lib -I../src -I/d/gnu/bzr/emacs/msys-build/src -mtune=pentium4 -DGLYPH_DEBUG=1 -DUSE_CRT_DLL=1 -I /d/gnu/bzr/emacs/msys-build/nt/inc -O0 -gdwarf-2 -g3 -MT qset-acl.o -MD -MP -MF .deps/qset-acl.Tpo -c -o qset-acl.o qset-acl.c qset-acl.c:71:6: #error Must have acl_delete_def_file (see POSIX 1003.1e draft 17). qset-acl.c: In function `qset_acl': qset-acl.c:127: warning: implicit declaration of function `acl_delete_def_file' Makefile:1449: recipe for target `qset-acl.o' failed make[2]: *** [qset-acl.o] Error 1 I was able to get past that by removing qset-acl.c from this line in nt/gnulib.mk: libgnu_a_SOURCES += acl-errno-valid.c file-has-acl.c qcopy-acl.c qset-acl.c However, I'd rather not remove parts of gnulib modules, I prefer to either include the whole module or none of it. Perhaps some simple change in qset-acl.c would be possible to work around this issue? After all qcopy_acl will not be called by the Windows build, so it is not important what it does. Alternatively, perhaps the qacl module could be broken into 2: one that includes the acl-errno-valid.c file, which is the only one the Windows build really needs, the other with the rest. Then the Windows build could use only the former. Paul, can you help me out here? Thanks.