unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: MS-Windows build using Posix configury
Date: Thu, 16 May 2013 09:00:51 +0300	[thread overview]
Message-ID: <83txm34g6k.fsf@gnu.org> (raw)
In-Reply-To: <83wqr297da.fsf@gnu.org>

> Date: Mon, 13 May 2013 19:23:13 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> With this out of my way, I need to update the branch to handle the
> changes in the configury committed lately to the trunk, to handle the
> ACL portability.  (I was actually hoping that something like this
> would happen, because I want to see how much effort is needed to make
> such adaptations.)  Before I adapt to that change, I cannot merge my
> branch onto the trunk, because the result will most probably fail to
> compile.  I hope to do that in a couple of days, and then I'll merge
> and announce.
> 
> Stay tuned, and thanks for encouragement.

I'm almost done.  Adapting to the new gnulib module was easy, which is
really good news.

There's one minor issue, though.  qset-acl.c didn't compile, because
it requires the acl_delete_def_file function:

  gcc  -std=gnu99 -DHAVE_CONFIG_H -I. -I/d/gnu/bzr/emacs/msys-build/lib -I../src -I/d/gnu/bzr/emacs/msys-build/src    -mtune=pentium4  -DGLYPH_DEBUG=1 -DUSE_CRT_DLL=1 -I /d/gnu/bzr/emacs/msys-build/nt/inc    -O0 -gdwarf-2 -g3 -MT qset-acl.o -MD -MP -MF .deps/qset-acl.Tpo -c -o qset-acl.o qset-acl.c
  qset-acl.c:71:6: #error Must have acl_delete_def_file (see POSIX 1003.1e draft 17).
  qset-acl.c: In function `qset_acl':
  qset-acl.c:127: warning: implicit declaration of function `acl_delete_def_file'
  Makefile:1449: recipe for target `qset-acl.o' failed
  make[2]: *** [qset-acl.o] Error 1

I was able to get past that by removing qset-acl.c from this line in
nt/gnulib.mk:

  libgnu_a_SOURCES += acl-errno-valid.c file-has-acl.c qcopy-acl.c qset-acl.c

However, I'd rather not remove parts of gnulib modules, I prefer to
either include the whole module or none of it.  Perhaps some simple
change in qset-acl.c would be possible to work around this issue?
After all qcopy_acl will not be called by the Windows build, so it is
not important what it does.

Alternatively, perhaps the qacl module could be broken into 2: one
that includes the acl-errno-valid.c file, which is the only one the
Windows build really needs, the other with the rest.  Then the Windows
build could use only the former.

Paul, can you help me out here?  Thanks.



  reply	other threads:[~2013-05-16  6:00 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 18:24 MS-Windows build using Posix configury Eli Zaretskii
2013-04-16 18:40 ` Eli Zaretskii
2013-04-16 20:13 ` Stefan Monnier
2013-04-17  2:53   ` Eli Zaretskii
2013-04-16 21:17 ` Glenn Morris
2013-04-17  2:56   ` Eli Zaretskii
2013-04-17  6:25     ` Glenn Morris
2013-04-17 16:48       ` Eli Zaretskii
2013-04-17 17:11         ` Glenn Morris
2013-04-17 17:34           ` Eli Zaretskii
2013-04-17 17:53             ` Glenn Morris
2013-04-17 18:15               ` Glenn Morris
2013-04-17 18:44                 ` Eli Zaretskii
2013-04-17  0:42 ` Glenn Morris
2013-04-17  2:57   ` Eli Zaretskii
2013-04-17  6:24     ` Glenn Morris
2013-04-17  3:33 ` Paul Eggert
2013-04-17 17:00   ` Eli Zaretskii
2013-04-17 18:48     ` Paul Eggert
2013-04-17 19:15       ` Glenn Morris
2013-04-17 19:45         ` Eli Zaretskii
2013-04-17 20:43           ` Glenn Morris
2013-04-17 21:19         ` Paul Eggert
2013-04-17 22:38           ` Glenn Morris
2013-04-18  0:52             ` Paul Eggert
2013-04-18  5:29               ` Glenn Morris
2013-04-18 16:11                 ` Eli Zaretskii
2013-04-17  6:27 ` Glenn Morris
2013-04-17  6:31 ` Glenn Morris
2013-04-18 19:32 ` Dani Moncayo
2013-04-18 20:27   ` Dani Moncayo
2013-04-18 21:20   ` Eli Zaretskii
2013-04-18 22:03     ` Dani Moncayo
2013-04-19  6:34       ` Eli Zaretskii
2013-04-19 20:17         ` Dani Moncayo
2013-04-20  6:34           ` Eli Zaretskii
2013-04-20  7:35             ` Dani Moncayo
2013-04-20  7:56               ` Eli Zaretskii
2013-04-20 17:18                 ` Dani Moncayo
2013-04-20 18:30                   ` Eli Zaretskii
2013-04-20 20:21                     ` Dani Moncayo
2013-04-21 15:12                       ` Eli Zaretskii
2013-04-21 19:53                         ` Dani Moncayo
2013-05-01 15:30                           ` Dani Moncayo
2013-05-01 16:30                             ` Eli Zaretskii
2013-05-01 19:30                               ` Dani Moncayo
2013-05-01 19:40                                 ` Eli Zaretskii
2013-05-02  6:43                                   ` Dani Moncayo
2013-05-02 16:19                                     ` Eli Zaretskii
2013-05-02 18:40                                       ` Dani Moncayo
2013-05-02 19:49                                         ` Eli Zaretskii
2013-05-02 21:42                                           ` Dani Moncayo
2013-05-02 21:43                                             ` Dani Moncayo
2013-05-03  8:50                                             ` Eli Zaretskii
2013-05-04 10:59                                               ` Dani Moncayo
2013-05-04 11:04                                                 ` Dani Moncayo
2013-05-04 11:27                                                 ` Eli Zaretskii
2013-05-04 12:00                                                   ` Dani Moncayo
2013-05-04 12:30                                                     ` Eli Zaretskii
2013-05-07 19:36                                                       ` Dani Moncayo
2013-05-07 21:13                                                         ` Eli Zaretskii
2013-05-07 22:04                                                           ` Dani Moncayo
2013-05-08 17:09                                                             ` Eli Zaretskii
2013-05-08 17:32                                                               ` Dani Moncayo
2013-05-13 12:23                                                               ` Andy Moreton
2013-05-13 16:23                                                                 ` Eli Zaretskii
2013-05-16  6:00                                                                   ` Eli Zaretskii [this message]
2013-05-16  6:31                                                                     ` Paul Eggert
2013-05-16  6:56                                                                       ` Eli Zaretskii
2013-05-16  7:16                                                                         ` Paul Eggert
2013-05-16  7:30                                                                           ` Eli Zaretskii
2013-05-16 13:19                                                                     ` Eli Zaretskii
2013-05-16 14:43                                                                       ` Dmitry Gutov
2013-05-16 15:41                                                                         ` Eli Zaretskii
2013-05-16 16:10                                                                           ` Dmitry Gutov
2013-05-16 17:17                                                                             ` Dani Moncayo
2013-05-16 17:54                                                                               ` Eli Zaretskii
2013-05-16 18:01                                                                                 ` Dani Moncayo
2013-05-16 18:36                                                                                   ` Eli Zaretskii
2013-05-16 21:02                                                                                 ` Dmitry Gutov
2013-05-17  6:02                                                                                   ` Eli Zaretskii
2013-05-16 17:18                                                                             ` Eli Zaretskii
2013-05-16 21:19                                                                               ` Dmitry Gutov
2013-05-17  9:39                                                                                 ` Eli Zaretskii
2013-05-17 12:05                                                                                   ` Dmitry Gutov
2013-05-17 13:13                                                                                     ` Eli Zaretskii
2013-05-17 14:03                                                                                       ` Dmitry Gutov
2013-05-17 14:26                                                                                         ` Eli Zaretskii
2013-05-17 15:29                                                                                           ` Dmitry Gutov
2013-05-17 16:05                                                                                             ` Eli Zaretskii
2013-05-17 16:30                                                                                               ` Dmitry Gutov
2013-05-17 17:40                                                                                                 ` Eli Zaretskii
2013-05-17 18:43                                                                                                   ` Eli Zaretskii
2013-05-17 20:47                                                                                                     ` Dmitry Gutov
2013-05-18  7:18                                                                                                       ` Eli Zaretskii
2013-05-18  8:08                                                                                                         ` Dmitry Gutov
2013-05-18  9:08                                                                                                           ` Eli Zaretskii
2013-05-18 13:24                                                                                                             ` Dmitry Gutov
2013-05-18 14:25                                                                                                               ` Eli Zaretskii
2013-05-18 14:28                                                                                                                 ` Dmitry Gutov
2013-05-18 18:21                                                                                                                   ` Eli Zaretskii
2013-05-18 18:42                                                                                                                     ` Dmitry Gutov
2013-05-18 18:53                                                                                                                       ` Eli Zaretskii
2013-05-18 19:15                                                                                                                         ` Dmitry Gutov
2013-05-18 19:24                                                                                                                           ` Eli Zaretskii
2013-06-07  8:51                                                                                                                           ` Eli Zaretskii
2013-06-07  9:36                                                                                                                             ` Dmitry Gutov
2013-06-07  9:56                                                                                                                               ` Eli Zaretskii
2013-05-19  6:48                                                                         ` Stephen Leake
2013-05-19 14:51                                                                           ` Eli Zaretskii
2013-05-21  8:31                                                                             ` Stephen Leake
2013-05-21 17:07                                                                               ` Eli Zaretskii
2013-05-21 19:36                                                                                 ` Stephen Leake
2013-05-25  7:29                                                                                   ` Eli Zaretskii
2013-04-19  3:05 ` Ken Brown
2013-04-19  6:35   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83txm34g6k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).