From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: the state of the concurrency branch Date: Mon, 26 Aug 2013 21:51:41 +0300 Message-ID: <83txicffpe.fsf@gnu.org> References: <87vc2t7erx.fsf@fleche.redhat.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1377543108 29646 80.91.229.3 (26 Aug 2013 18:51:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Aug 2013 18:51:48 +0000 (UTC) Cc: tromey@redhat.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 26 20:51:48 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VE1tC-0007B4-0J for ged-emacs-devel@m.gmane.org; Mon, 26 Aug 2013 20:51:46 +0200 Original-Received: from localhost ([::1]:52760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE1tB-0006vE-Jf for ged-emacs-devel@m.gmane.org; Mon, 26 Aug 2013 14:51:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE1t3-0006v2-Oo for emacs-devel@gnu.org; Mon, 26 Aug 2013 14:51:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VE1sx-0003iz-CW for emacs-devel@gnu.org; Mon, 26 Aug 2013 14:51:37 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VE1sx-0003il-4D for emacs-devel@gnu.org; Mon, 26 Aug 2013 14:51:31 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MS500A00IZZKZ00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Mon, 26 Aug 2013 21:51:29 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MS500A7UJ1SBQ40@a-mtaout22.012.net.il>; Mon, 26 Aug 2013 21:51:29 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163039 Archived-At: > From: Juanma Barranquero > Date: Mon, 26 Aug 2013 19:04:46 +0200 > Cc: Tom Tromey , Emacs discussions > > On Mon, Aug 26, 2013 at 6:48 PM, Stefan Monnier > wrote: > > >> What would it take to merge the branch to trunk? > > > > It sounds like it's close to ready for merge, indeed. > > Well, it breaks the Windows build. I fixed the compilation, but the stuff in process.c needs work: if you invoke "M-x grep", Emacs aborts after Grep exits, here: void delete_read_fd (int fd) { eassert (fd < MAXDESC); eassert (fd <= max_desc); <<<<<<<<<<<<<<<<< because max_desc is zero. In general, I'd be grateful if Someone(TM) could explain the main changes in process.c, as it's pretty basic stuff, and some of the changes would originally not even compile, because some variables involved in the changes were declared conditionally. Since I couldn't grasp the rationale for the changes in the few minutes I had to spare, I'm not sure I fixed the code correctly. Finally, there's a warning in regex.c: regex.c: In function `re_set_whitespace_regexp': regex.c:1250: warning: assignment discards qualifiers from pointer target type but I don't think it's Windows specific. In sum, I'd say this branch still "needs work". Thanks.