From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 19:13:47 +0300 Message-ID: <83twft8qis.fsf@gnu.org> References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> <83inw9a9tl.fsf@gnu.org> <83wpkp8s9g.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468426477 20440 80.91.229.3 (13 Jul 2016 16:14:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 16:14:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 18:14:36 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNMnx-0005Vp-Lu for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 18:14:33 +0200 Original-Received: from localhost ([::1]:48820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMnw-0001ds-S1 for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 12:14:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMnm-0001bw-A6 for emacs-devel@gnu.org; Wed, 13 Jul 2016 12:14:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNMnh-0003fJ-7u for emacs-devel@gnu.org; Wed, 13 Jul 2016 12:14:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMnh-0003fE-51; Wed, 13 Jul 2016 12:14:17 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4124 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNMne-0001iz-9n; Wed, 13 Jul 2016 12:14:16 -0400 In-reply-to: (message from Stefan Monnier on Wed, 13 Jul 2016 11:42:45 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205656 Archived-At: > From: Stefan Monnier > Date: Wed, 13 Jul 2016 11:42:45 -0400 > > > If they must first check if there's a defgroup in the same file, and > > The byte-compiler will complain if a defcustom doesn't have a :group and > there's no preceding defgroup (as was the case in the situation that > started this discussion). So I don't think it's too much of a problem. It's evidently a problem. Otherwise, I wouldn't have had to ask Stephen to take care of those warnings. > > then if there's more than one defgroup, make sure the defcustom is > > after the right one, then this is an error-prone system which cannot > > be trusted. > > Then let's restrict the current system so it also complains if there's > no :group yet there are more than one preceding defgroup. I think this cure will be worse than the decease.