From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] Support 24-bit terminal colors. Date: Sun, 12 Feb 2017 22:47:24 +0200 Message-ID: <83tw7z16hv.fsf@gnu.org> References: <1486893930-6709-1-git-send-email-rami.ylimaki@vincit.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1486932478 811 195.159.176.226 (12 Feb 2017 20:47:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Feb 2017 20:47:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Rami =?utf-8?Q?Ylim=C3=A4ki?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 12 21:47:55 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd13q-0008OK-R1 for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2017 21:47:54 +0100 Original-Received: from localhost ([::1]:53392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd13w-0000Vq-JS for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2017 15:48:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd13N-0000VY-HS for emacs-devel@gnu.org; Sun, 12 Feb 2017 15:47:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd13K-00066I-GC for emacs-devel@gnu.org; Sun, 12 Feb 2017 15:47:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd13K-00066E-DB; Sun, 12 Feb 2017 15:47:22 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4108 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cd13J-00032P-Da; Sun, 12 Feb 2017 15:47:22 -0500 In-reply-to: <1486893930-6709-1-git-send-email-rami.ylimaki@vincit.fi> (message from Rami =?utf-8?Q?Ylim=C3=A4ki?= on Sun, 12 Feb 2017 12:05:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212308 Archived-At: > From: Rami Ylimäki > Date: Sun, 12 Feb 2017 12:05:27 +0200 > > I have tested these changes on gnome-terminal/Ubuntu and iTerm2/OSX. > > Rami Ylimäki (3): > Remove unused terminal color pair count. > Support 24-bit terminal colors. > Let user turn 24-bit terminal colors on. > > lisp/term/tty-colors.el | 19 +++++++++++++++++-- > lisp/term/xterm.el | 8 ++++++++ > src/term.c | 20 ++++++++++++++------ > src/termchar.h | 4 ---- > src/tparam.h | 4 ++++ > 5 files changed, 43 insertions(+), 12 deletions(-) Thanks. This looks very good. A couple of comments: . Please prepare a NEWS entry for this feature. . It seems like you dropped the code to support the --color= command-line argument, which was part of your original submission? All the other color TTY modes support --color=NUM, so I think we should also support --color=16777216, and perhaps also --color-24bit. . If you agree to add the code for the previous item, the Emacs user manual should need an update (node "Colors X", where the --color option is described). Thanks again for working on this.