From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: User-defined record types, v2
Date: Sun, 19 Mar 2017 16:51:49 +0200 [thread overview]
Message-ID: <83tw6pwc8q.fsf@gnu.org> (raw)
In-Reply-To: <jwvinn5mnz0.fsf-monnier+gmane.emacs.devel@gnu.org> (message from Stefan Monnier on Sun, 19 Mar 2017 08:50:24 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sun, 19 Mar 2017 08:50:24 -0400
>
> >> But I'm not even sure we should enforce this in the `record` and
> >> `make-record` primitives. After all, it's not needed for safety. And
> >> since we allow (aset <obj> 0 <foo>) we can circumvent this check
> >> anyway.
> > Not quite. `aset' does the check too.
>
> Hm... so this slows down every use of `aset` on records, 99.99% of which
> affect another slot anyway!
>
> > But then, so much else in Emacs depends on people doing sensible
> > things, so maybe no check is needed at all.
>
> Exactly.
>
> > If we come up with a need for a check, we know where to add it. If not,
> > I can just delete the unused code.
>
> That'd be my choice.
We could instead leave it in an eassert.
next prev parent reply other threads:[~2017-03-19 14:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 17:04 User-defined record types, v2 Lars Brinkhoff
2017-03-18 17:05 ` Lars Brinkhoff
2017-03-18 17:13 ` Lars Brinkhoff
2017-03-18 17:17 ` Lars Brinkhoff
2017-03-18 17:21 ` Lars Brinkhoff
2017-03-18 17:35 ` Eli Zaretskii
2017-03-18 19:33 ` Lars Brinkhoff
2017-03-18 22:24 ` Stefan Monnier
2017-03-19 9:17 ` Lars Brinkhoff
2017-03-19 12:50 ` Stefan Monnier
2017-03-19 14:51 ` Eli Zaretskii [this message]
2017-03-18 17:29 ` Eli Zaretskii
2017-03-19 10:28 ` Lars Brinkhoff
2017-03-19 12:51 ` Stefan Monnier
2017-03-21 9:55 ` Lars Brinkhoff
2017-03-21 11:53 ` Stefan Monnier
2017-03-22 21:15 ` Stefan Monnier
2017-03-23 6:53 ` Lars Brinkhoff
2017-03-23 7:02 ` Lars Brinkhoff
2017-03-23 7:34 ` Lars Brinkhoff
2017-03-23 19:47 ` Stefan Monnier
2017-03-24 10:15 ` Lars Brinkhoff
2017-03-24 18:17 ` Stefan Monnier
2017-03-24 20:38 ` Lars Brinkhoff
2017-03-29 12:46 ` Lars Brinkhoff
2017-03-30 12:59 ` Stefan Monnier
2017-03-30 14:57 ` Lars Brinkhoff
2017-03-30 15:07 ` Stefan Monnier
2017-03-30 18:10 ` Eli Zaretskii
2017-03-22 7:58 ` Lars Brinkhoff
2017-03-22 8:46 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tw6pwc8q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).