* Re: master ac2ca82: Simplify test dependency generation
[not found] ` <20170401191624.40306220C2@vcs0.savannah.gnu.org>
@ 2017-04-02 15:20 ` Glenn Morris
2017-04-02 20:15 ` Paul Eggert
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2017-04-02 15:20 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Eggert
Hi,
Paul Eggert wrote:
> branch: master
> commit ac2ca82eb19bbf7f1cac7ec3f6c020ebf2b15882
>
> Simplify test dependency generation
Prior to this change, I could run specific tests using eg
cd test
make lisp/vc/ediff-ptch-tests
Now that fails with:
make: *** No rule to make target `../lisp/lisp/vc/ediff-ptch-tests',
needed by `lisp/vc/ediff-ptch-tests'. Stop.
The version with ".log" appended still works, but doesn't behave the same.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master ac2ca82: Simplify test dependency generation
2017-04-02 15:20 ` master ac2ca82: Simplify test dependency generation Glenn Morris
@ 2017-04-02 20:15 ` Paul Eggert
2017-04-02 20:59 ` Phillip Lord
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggert @ 2017-04-02 20:15 UTC (permalink / raw)
To: Glenn Morris, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
On 04/02/2017 08:20 AM, Glenn Morris wrote:
> make: *** No rule to make target `../lisp/lisp/vc/ediff-ptch-tests',
> needed by `lisp/vc/ediff-ptch-tests'. Stop.
>
> The version with ".log" appended still works, but doesn't behave the same.
Sorry about that. Evidently I didn't understand the test procedure well
enough. I gave it another shot by installing the attached.
[-- Attachment #2: 0001-Fix-bugs-in-simplified-test-dependencies.patch --]
[-- Type: application/x-patch, Size: 3228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master ac2ca82: Simplify test dependency generation
2017-04-02 20:15 ` Paul Eggert
@ 2017-04-02 20:59 ` Phillip Lord
2017-04-03 2:30 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Phillip Lord @ 2017-04-02 20:59 UTC (permalink / raw)
To: Paul Eggert; +Cc: Glenn Morris, emacs-devel
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 04/02/2017 08:20 AM, Glenn Morris wrote:
>> make: *** No rule to make target `../lisp/lisp/vc/ediff-ptch-tests',
>> needed by `lisp/vc/ediff-ptch-tests'. Stop.
>>
>> The version with ".log" appended still works, but doesn't behave the same.
>
> Sorry about that. Evidently I didn't understand the test procedure well
> enough. I gave it another shot by installing the attached.
I probably made this over-complicated. In my head, I figured that if I
was running an individual test file, it should always run. Perhaps I
should have put all this information at one point in the makefile.
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master ac2ca82: Simplify test dependency generation
2017-04-02 20:59 ` Phillip Lord
@ 2017-04-03 2:30 ` Eli Zaretskii
2017-04-03 11:11 ` Phillip Lord
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2017-04-03 2:30 UTC (permalink / raw)
To: Phillip Lord; +Cc: rgm, eggert, emacs-devel
> From: phillip.lord@russet.org.uk (Phillip Lord)
> Date: Sun, 02 Apr 2017 21:59:00 +0100
> Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
>
> > Sorry about that. Evidently I didn't understand the test procedure well
> > enough. I gave it another shot by installing the attached.
>
> I probably made this over-complicated. In my head, I figured that if I
> was running an individual test file, it should always run. Perhaps I
> should have put all this information at one point in the makefile.
It's not too late to add that.
TIA
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master ac2ca82: Simplify test dependency generation
2017-04-03 2:30 ` Eli Zaretskii
@ 2017-04-03 11:11 ` Phillip Lord
0 siblings, 0 replies; 5+ messages in thread
From: Phillip Lord @ 2017-04-03 11:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: rgm, eggert, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Date: Sun, 02 Apr 2017 21:59:00 +0100
>> Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
>>
>> > Sorry about that. Evidently I didn't understand the test procedure well
>> > enough. I gave it another shot by installing the attached.
>>
>> I probably made this over-complicated. In my head, I figured that if I
>> was running an individual test file, it should always run. Perhaps I
>> should have put all this information at one point in the makefile.
>
> It's not too late to add that.
I will!
Phil
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-03 11:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170401191623.27276.43356@vcs0.savannah.gnu.org>
[not found] ` <20170401191624.40306220C2@vcs0.savannah.gnu.org>
2017-04-02 15:20 ` master ac2ca82: Simplify test dependency generation Glenn Morris
2017-04-02 20:15 ` Paul Eggert
2017-04-02 20:59 ` Phillip Lord
2017-04-03 2:30 ` Eli Zaretskii
2017-04-03 11:11 ` Phillip Lord
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).