From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sat, 06 May 2017 23:03:48 +0300 Message-ID: <83tw4xeorf.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1494101121 6908 195.159.176.226 (6 May 2017 20:05:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 May 2017 20:05:21 +0000 (UTC) Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, emacs-devel@gnu.org, tino.calancha@gmail.com To: Johan =?utf-8?Q?Bockg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 06 22:05:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d75x6-0001iT-Md for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 22:05:16 +0200 Original-Received: from localhost ([::1]:52542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d75xC-00010m-By for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 16:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d75wY-00010V-Ib for emacs-devel@gnu.org; Sat, 06 May 2017 16:04:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d75wU-0003a7-4t for emacs-devel@gnu.org; Sat, 06 May 2017 16:04:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d75wU-0003a3-1a; Sat, 06 May 2017 16:04:38 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3547 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d75wR-0004gB-0i; Sat, 06 May 2017 16:04:37 -0400 In-reply-to: <87vapdhi9j.fsf@gnu.org> (message from Johan =?utf-8?Q?Bockg?= =?utf-8?Q?=C3=A5rd?= on Sat, 06 May 2017 21:55:52 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214635 Archived-At: > From: Johan Bockgård > Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, tino.calancha@gmail.com, emacs-devel@gnu.org > Date: Sat, 06 May 2017 21:55:52 +0200 > > Eli Zaretskii writes: > > >> From: Johan Bockgård > >> Cc: Eli Zaretskii , mvoteiza@udel.edu, > >> emacs-devel@gnu.org, tino.calancha@gmail.com > >> Date: Sat, 06 May 2017 19:51:33 +0200 > >> > >> > + (if (string-match (concat "\\`" (or regexp "[ \t\n\r]+")) string) > >> > >> I think regexp should be surrounded by a grouping construct, like: > >> > >> (concat "\\`\\(?:" (or regexp "[ \t\n\r]+") "\\)") > >> > >> And similarly for string-trim-right. > > > > Rationale? > > regexp can contain \| Shouldn't such a regexp be surrounded by "\\(..\\)"?