From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: BUFFER_SWITCH_EVENT
Date: Tue, 25 Sep 2018 20:28:44 +0300 [thread overview]
Message-ID: <83tvmd8p0z.fsf@gnu.org> (raw)
In-Reply-To: <jwvsh1x4hz4.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 25 Sep 2018 13:19:34 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: emacs-devel@gnu.org
> Date: Tue, 25 Sep 2018 13:19:34 -0400
>
> >> We already look them up presumably in the right place. I don't
> >> understand why we'd need to look them up again after running
> >> a process filter.
> > Because a filter could have switched buffers, I presume.
>
> I don't follow:
>
> 1- we enter read-key-sequence
> 2- we read the set of keymaps
> 3- some process filter is executed, changing the current buffer
> 4- the set of keymaps that we need to use is still the same we computed
> at 2 and the keymaps themselves are also still the same
>
> What am I missing?
You are asking the wrong guy, but I will try anyway: since the buffer
changed, we need to replay the key sequence using the keymaps local to
that buffer, not the ones we computed at 2. Right?
next prev parent reply other threads:[~2018-09-25 17:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:24 while-no-input interrupted by *shell* Michael Heerdegen
2018-09-24 16:14 ` Eli Zaretskii
2018-09-24 16:40 ` Stefan Monnier
2018-09-24 17:00 ` Eli Zaretskii
2018-09-24 18:35 ` Stefan Monnier
2018-09-24 18:48 ` Eli Zaretskii
2018-09-24 17:39 ` Michael Heerdegen
2018-09-24 18:00 ` Eli Zaretskii
2018-09-24 19:09 ` Michael Heerdegen
2018-09-24 19:06 ` Stefan Monnier
2018-09-25 13:09 ` Eli Zaretskii
2018-09-25 13:39 ` Michael Heerdegen
2018-09-25 14:14 ` Eli Zaretskii
2018-09-29 7:13 ` Eli Zaretskii
2018-09-25 15:25 ` BUFFER_SWITCH_EVENT (was: while-no-input interrupted by *shell*) Stefan Monnier
2018-09-25 16:01 ` Eli Zaretskii
2018-09-25 16:14 ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 16:28 ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 17:19 ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 17:28 ` Eli Zaretskii [this message]
2018-09-25 18:14 ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-25 18:32 ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 19:05 ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-25 21:50 ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-26 5:42 ` BUFFER_SWITCH_EVENT Eli Zaretskii
2018-09-26 12:27 ` BUFFER_SWITCH_EVENT Stefan Monnier
2018-09-24 21:23 ` while-no-input interrupted by *shell* Andreas Schwab
2018-09-25 10:36 ` Michael Heerdegen
2018-09-24 16:19 ` Stefan Monnier
2018-09-25 17:47 ` while-no-input and pending input (was: while-no-input interrupted by *shell*) Michael Heerdegen
2018-09-25 17:53 ` Drew Adams
2018-09-26 12:50 ` while-no-input and pending input Michael Heerdegen
2018-09-26 14:18 ` while-no-input and pending input (was: while-no-input interrupted by *shell*) Eli Zaretskii
2018-09-26 17:57 ` while-no-input and pending input Michael Heerdegen
2018-09-26 19:06 ` Eli Zaretskii
2018-10-12 15:38 ` Michael Heerdegen
2018-10-12 15:44 ` Stefan Monnier
2019-02-17 23:44 ` Michael Heerdegen
2019-02-18 17:08 ` Eli Zaretskii
2019-02-18 19:08 ` Óscar Fuentes
2019-02-18 19:23 ` Eli Zaretskii
2019-02-18 22:32 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvmd8p0z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).