From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources (was: The poor state of documentation of pcase like things.) Date: Tue, 23 Oct 2018 18:17:29 +0300 Message-ID: <83tvlcsnee.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <87bn95m9eg.fsf@fencepost.gnu.org> <5686CDFB.2010105@dancol.org> <83fuygcs5g.fsf@gnu.org> <56886E32.70305@yandex.ru> <83si2f9ve4.fsf@gnu.org> <56889EC3.3040108@yandex.ru> <877fjrkpdf.fsf@fencepost.gnu.org> <56892334.4000106@yandex.ru> <8760zakb7q.fsf@fencepost.gnu.org> <56892BDA.6060103@dancol.org> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540307756 2331 195.159.176.226 (23 Oct 2018 15:15:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2018 15:15:56 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 17:15:52 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEyPQ-0000Vi-33 for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 17:15:52 +0200 Original-Received: from localhost ([::1]:42654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEyRW-0001kF-Le for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 11:18:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEyRH-0001eN-61 for emacs-devel@gnu.org; Tue, 23 Oct 2018 11:17:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEyRG-0005F9-DS for emacs-devel@gnu.org; Tue, 23 Oct 2018 11:17:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEyRA-00053R-EA; Tue, 23 Oct 2018 11:17:40 -0400 Original-Received: from [176.228.60.248] (port=4752 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gEyRA-0001PN-14; Tue, 23 Oct 2018 11:17:40 -0400 In-reply-to: <87h8hc4xw2.fsf_-_@web.de> (message from Michael Heerdegen on Tue, 23 Oct 2018 15:04:45 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230589 Archived-At: > From: Michael Heerdegen > Cc: Stefan Monnier , > Eli Zaretskii > Date: Tue, 23 Oct 2018 15:04:45 +0200 > > Some time (two years) ago I volunteered to replace lots of the `pcase' > occurrences in the Emacs sources (back) to cl-case where possible. Lots > of people wanted this because they found understanding pcase expressions > hard. > > I would like to do that now. Thank you. If you find places where pcase is used, but a simple cond will do (without obfuscating the code, of course), please use cond where appropriate. > Or has the mood of people changed in the meantime due to the improved > documentation of `pcase'? Mine didn't (and I do appreciate the improvement in the docs). > A question: when I compose the commit message, I can write something > like "Change all affected callers in all files" instead of listing all > individual changed functions separately, right? "All callers changed" is the usual wording.