From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Mon, 05 Nov 2018 18:06:29 +0200 Message-ID: <83tvkvcxve.fsf@gnu.org> References: <20151216202605.GA3752@acm.fritz.box> <87h8hc4xw2.fsf_-_@web.de> <83tvlcsnee.fsf@gnu.org> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> <831s89mo03.fsf@gnu.org> <87pnvsifxt.fsf@web.de> <83muqwkkt1.fsf@gnu.org> <875zxjv3ku.fsf@web.de> <83o9bbjqcj.fsf@gnu.org> <87r2g7t7bo.fsf@web.de> <83tvl2hzt6.fsf@gnu.org> <87r2g5x3gk.fsf@web.de> <87va5gzxyk.fsf@web.de> <87lg6czxo9.fsf@web.de> <87y3a8jo2r.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541434639 13693 195.159.176.226 (5 Nov 2018 16:17:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2018 16:17:19 +0000 (UTC) Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 17:17:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJhYv-0003Pi-RI for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2018 17:17:13 +0100 Original-Received: from localhost ([::1]:36016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhb1-00059y-UG for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2018 11:19:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhak-0004qP-T4 for emacs-devel@gnu.org; Mon, 05 Nov 2018 11:19:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJhP9-000283-Rr for emacs-devel@gnu.org; Mon, 05 Nov 2018 11:07:13 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhOd-0001d6-NU; Mon, 05 Nov 2018 11:06:38 -0500 Original-Received: from [176.228.60.248] (port=1549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gJhOa-0005HF-HF; Mon, 05 Nov 2018 11:06:33 -0500 In-reply-to: <87y3a8jo2r.fsf@web.de> (message from Michael Heerdegen on Mon, 05 Nov 2018 02:43:56 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231029 Archived-At: > From: Michael Heerdegen > Cc: Eli Zaretskii , Stefan Monnier , Noam Postavsky > Date: Mon, 05 Nov 2018 02:43:56 +0100 > > For now, I attach a patch were I replaced nearly everything where it was > possible. Comments welcome. If we are sure which changes we want to > keep, I'll do the final fine-tuning (fixing indentation and comments, if > some were shifted, etc.) > > BTW, some files use backquotes very excessively, mainly > lisp/progmodes/verilog-mode.el. I guess verilog consists mainly of > backquotes? > > There were some backquoted function names and lambdas. I replaced the > backquote with #' (symbols), and most of the time nothing (lambdas in > lexical binding files). I was very conservative with lambdas in files > that didn't use lexbind. > > Finally, the thing I found in lisp/calendar/time-date.el looked like a > bug to me I found by accident. > > I'm attaching the patch. I obviously didn't proofread all of the changes, but what I did looked good. Thanks.