From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native image rotation Date: Sun, 24 Feb 2019 18:14:30 +0200 Message-ID: <83tvgtnoyh.fsf@gnu.org> References: <20190224113050.GA67303@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203292"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 24 17:14:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxwQI-000qlY-7z for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 17:14:38 +0100 Original-Received: from localhost ([127.0.0.1]:52991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwQH-0001QJ-4y for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 11:14:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwQ5-0001PH-M1 for emacs-devel@gnu.org; Sun, 24 Feb 2019 11:14:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwQ2-0006A5-Mr; Sun, 24 Feb 2019 11:14:22 -0500 Original-Received: from [176.228.60.248] (port=4488 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxwQ2-0002rd-4U; Sun, 24 Feb 2019 11:14:22 -0500 In-reply-to: <20190224113050.GA67303@breton.holly.idiocy.org> (message from Alan Third on Sun, 24 Feb 2019 11:30:50 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233566 Archived-At: > Date: Sun, 24 Feb 2019 11:30:50 +0000 > From: Alan Third > > I’ve attached a couple of patches. The second renames image scaling to > image transforms, as it covers more than just scaling. > > It should be trivial to add cropping now. I can’t think of anything > else we might want to support. > > Again I’ve not handled Windows, but hopefully it’s quite > straight‐forward. > > The image rotation code is very explicit in what it’s doing and could > be optimized, but I’m not sure it matters. Thanks. Though I wonder what would be the use cases for rotating images in Emacs by angles other than integral multiples of 90 deg.