From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken. Date: Fri, 01 Mar 2019 09:31:08 +0200 Message-ID: <83tvgnhwzn.fsf@gnu.org> References: <20190228202146.GC4686@ACM> <20190228205955.GD4686@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="59327"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 01 08:34:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzcgF-000FKJ-JG for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 08:34:03 +0100 Original-Received: from localhost ([127.0.0.1]:52307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzcgE-0003EG-AH for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 02:34:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzcde-00028p-MN for emacs-devel@gnu.org; Fri, 01 Mar 2019 02:31:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzcde-0008Gv-7X; Fri, 01 Mar 2019 02:31:22 -0500 Original-Received: from [176.228.60.248] (port=3243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzcdd-0001pD-S1; Fri, 01 Mar 2019 02:31:22 -0500 In-reply-to: <20190228205955.GD4686@ACM> (message from Alan Mackenzie on Thu, 28 Feb 2019 20:59:55 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233718 Archived-At: > Date: Thu, 28 Feb 2019 20:59:55 +0000 > From: Alan Mackenzie > > OK, I've worked out what's to be done, and done it. dmpstruct.h is a > file containing up to date hashes of structures. The old hash in > pdumper.c needs to replaced by hand by the updated hash from > dmpstruct.h. My Emacs now builds. > > This is anything but clear from the comment at L71 in pdumper.c. It > says "and update the hash..." without saying which hash, and without > saying how. Which utility is needed to update this hash? (Answer: > none). Please feel free to improve the comments to clarify anything that is not crystal clear. TIA