From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter ->
	frame_parameter_pos change
Date: Tue, 16 Apr 2019 21:05:32 +0300
Message-ID: <83tvexg70z.fsf@gnu.org>
References: <20190416165204.7024.23185@vcs0.savannah.gnu.org>
	<20190416165207.442F52068F@vcs0.savannah.gnu.org>
	<m2y349ev8u.fsf@gmail.com> <87zhopc1ia.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="135287"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Alex Gramiak <agrambot@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 20:06:53 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGSTs-000Z4u-Qw
	for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 20:06:52 +0200
Original-Received: from localhost ([127.0.0.1]:40528 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGSTr-0008NR-NT
	for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 14:06:51 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:45275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hGSSn-0008Lt-6s
	for emacs-devel@gnu.org; Tue, 16 Apr 2019 14:05:46 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53538)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hGSSn-0005Q3-1Q; Tue, 16 Apr 2019 14:05:45 -0400
Original-Received: from [176.228.60.248] (port=1805 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hGSSj-00076H-2q; Tue, 16 Apr 2019 14:05:42 -0400
In-reply-to: <87zhopc1ia.fsf@gmail.com> (message from Alex Gramiak on Tue, 16
	Apr 2019 11:18:21 -0600)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235542
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235542>

> From: Alex Gramiak <agrambot@gmail.com>
> Date: Tue, 16 Apr 2019 11:18:21 -0600
> 
> Robert Pluim <rpluim@gmail.com> writes:
> 
> >   CC       xdisp.o
> > xdisp.c:29300:37: error: no member named 'x_highlight_frame' in
> >       'struct ns_display_info'; did you mean 'ns_highlight_frame'?
> >            || f != FRAME_DISPLAY_INFO (f)->x_highlight_frame)
> >                                            ^~~~~~~~~~~~~~~~~
> >                                            ns_highlight_frame
> > ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here
> >   struct frame *ns_highlight_frame;
> >                 ^
> > 1 error generated.
> >
> > (on macOS)
> 
> Ah, I originally renamed the x_highlight_frame on W32/NS to {w32,ns}_*,
> but decided against it since xdisp.c used the attribute directly (a hook
> or union interface could be added later). Perhaps it should be renamed
> native_highlight_frame until then, though.

Or just highlight_frame?