From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Line height issues with display-line-number-mode Date: Wed, 08 May 2019 17:05:14 +0300 Message-ID: <83tve5ghyd.fsf@gnu.org> References: <6fd496f0-7dd5-6c0e-5121-b618e7dca831@gmail.com> <83sgtqi02k.fsf@gnu.org> <83r29ahyz2.fsf@gnu.org> <83pnouhwxs.fsf@gnu.org> <83ef59igzc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211685"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 16:06:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hONDU-000soq-Ta for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 16:06:41 +0200 Original-Received: from localhost ([127.0.0.1]:37833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONDS-0002Hf-Sj for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 10:06:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONCc-00018q-IO for emacs-devel@gnu.org; Wed, 08 May 2019 10:05:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hONCc-00042t-AE; Wed, 08 May 2019 10:05:46 -0400 Original-Received: from [176.228.60.248] (port=4638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hONCW-0005pK-KG; Wed, 08 May 2019 10:05:43 -0400 In-reply-to: (message from Stefan Monnier on Wed, 08 May 2019 09:39:58 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236289 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Wed, 08 May 2019 09:39:58 -0400 > > > Btw, any reasons (other than "because we can") why we use these > > tricks, instead of actually producing an underline? > > Not sure what "producing an underline" means concretely. Using the 'underline' face, obviously. > > when we produce line numbers, so that we start the layout of the rest > > of the line with the height of, say, 1 pixel, and let the rest of the > > line's text enlarge that as needed. But doing this naïvely would > > backfire with various special cases, like empty lines, lines with > > characters whose font-provided height is small, etc.: those lines will > > appear smaller in height, > > Smaller than what? Smaller than other lines. > AFAICT they wouldn't appear any smaller than when line-numbers are > turned off, or would they? They might, I'm not sure.