From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0528a7c: Ensure that expand-file-name returns an absolute file name Date: Tue, 09 Jul 2019 05:35:35 +0300 Message-ID: <83tvbw5408.fsf@gnu.org> References: <20190708223951.10291.7621@vcs0.savannah.gnu.org> <20190708223953.3172920BD5@vcs0.savannah.gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118302"; mail-complaints-to="usenet@blaine.gmane.org" Cc: kbrown@cornell.edu, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 04:36:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkfzE-000Ua0-BG for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 04:36:08 +0200 Original-Received: from localhost ([::1]:46216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkfzC-0004Hx-Vo for ged-emacs-devel@m.gmane.org; Mon, 08 Jul 2019 22:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45246) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkfyz-0004Hp-4Q for emacs-devel@gnu.org; Mon, 08 Jul 2019 22:35:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hkfyy-0003i7-Cd; Mon, 08 Jul 2019 22:35:52 -0400 Original-Received: from [176.228.60.248] (port=2054 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hkfyx-0000BT-1Q; Mon, 08 Jul 2019 22:35:52 -0400 In-reply-to: (message from Stefan Monnier on Mon, 08 Jul 2019 19:13:52 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238425 Archived-At: > From: Stefan Monnier > Date: Mon, 08 Jul 2019 19:13:52 -0400 > Cc: emacs-devel@gnu.org > > > * src/fileio.c (Fexpand_file_name): Don't directly use the current > > buffer's default-directory if it is relative. Instead replace it > > by its expansion relative to invocation-directory. (Bug#36502) > > I don't think invocation-directory is a better choice than any > other directory. A relative `default-directory` value is an error. > We should signal that error rather than try and paper over it. In the bug discussion I explained why I thought this alternative was better.