From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Thu, 23 Jan 2020 21:22:33 +0200 Message-ID: <83tv4mrn9i.fsf@gnu.org> References: <6E80D3C1-CE0D-4BC4-BE86-CB833078A08E@icloud.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="17930"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jessenzr@gmail.com, emacs-devel@gnu.org To: =?utf-8?B?7KGw7ISx67mI?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 20:47:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuiSA-0004cs-R4 for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 20:47:46 +0100 Original-Received: from localhost ([::1]:60542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuiS9-0007H5-O5 for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 14:47:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60030) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iui3u-0003Gi-VQ for emacs-devel@gnu.org; Thu, 23 Jan 2020 14:22:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iui3u-0005bP-GN; Thu, 23 Jan 2020 14:22:42 -0500 Original-Received: from [176.228.60.248] (port=4026 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iui3t-0001U8-RO; Thu, 23 Jan 2020 14:22:42 -0500 In-reply-to: <6E80D3C1-CE0D-4BC4-BE86-CB833078A08E@icloud.com> (message from =?utf-8?B?7KGw7ISx67mI?= on Fri, 24 Jan 2020 01:32:21 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244545 Archived-At: > From: 조성빈 > Date: Fri, 24 Jan 2020 01:32:21 +0900 > Cc: jessenzr@gmail.com > > From 1302c040a23837b80a53416421914f3fe8ba1926 Mon Sep 17 00:00:00 2001 > From: Sungbin Jo > Date: Fri, 24 Jan 2020 00:56:38 +0900 > Subject: [PATCH] Add new variable for centering lines vertically. > > Co-authored-by: Jesse Nazario Most of the patch was written by Jesse, and we don't have a copyright assignment for Jesse on file. We need that to accept this contribution. > + if (NILP (BVAR (XBUFFER (it->w->contents), > + line_spacing_vertical_center))) No need to use BVAR here, since the buffer whose window is being displayed is always the current buffer when the display code runs. Thanks.