From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: "Why is emacs so square?" Date: Wed, 22 Apr 2020 17:29:38 +0300 Message-ID: <83tv1begq5.fsf@gnu.org> References: <8wXYP4GY9hwW-9mYv6_LGMETZ8Vz3Ob1Bec6yh6kPT7yxjTkxA3V6dXY4ELra9tYiJUxJmgXKSIEX4w8HFiPRoeGVSQHDSoBVy1voj1e3Qo=@protonmail.com> <833694f29y.fsf@gnu.org> <4amRIW9fznS6sa3th4xPABzua9LQDlNPeIFxVsGYdq_wsg4-Ea1l9sEP-T6QrnO5QMV3jhgrnAspk2mSIC7COlodqr04koAcIPYPLLmPHFM=@protonmail.com> <83imhzecc5.fsf@gnu.org> <83y2qvcjv6.fsf@gnu.org> <83k12ed20s.fsf@gnu.org> <83blnqctyj.fsf@gnu.org> <9341072a-cf53-9092-2211-aa97c946e5b1@yandex.ru> <838sinfygb.fsf@gnu.org> <16fad982-e95b-7df1-25d0-1c666a6f8120@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="115482"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 22 16:31:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRGPp-000Twh-D9 for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Apr 2020 16:31:53 +0200 Original-Received: from localhost ([::1]:51864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRGPo-0000vN-DC for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Apr 2020 10:31:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60182) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRGNy-00079E-3y for emacs-devel@gnu.org; Wed, 22 Apr 2020 10:29:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59399) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRGNx-00038t-S4; Wed, 22 Apr 2020 10:29:57 -0400 Original-Received: from [176.228.60.248] (port=3246 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jRGNw-0006Dr-LA; Wed, 22 Apr 2020 10:29:57 -0400 In-Reply-To: <16fad982-e95b-7df1-25d0-1c666a6f8120@gmail.com> (message from =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel on Wed, 22 Apr 2020 10:05:15 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247515 Archived-At: > From: Clément Pit-Claudel > Date: Wed, 22 Apr 2020 10:05:15 -0400 > > > I don't think I follow. Where can I find this "GNOME theme"? It's > > not part of the Emacs release tarball, is it? > > It's shipped by GNU/Linux distributions, typically. Any chance of getting a URL that I could explore? > > What exactly do you mean by "icons follow the theme"? how does a theme > > affect icons? > > In GTK builds (the default in Debian, and probably others), the toolbar uses icons from the current GTK icon theme. I believe this is done in update_frame_tool_bar in gtkutil.c. Then I don't understand the complaint. The icons that don't change are our private icons that aren't taken from GTK. So how can they "follow the theme", if they are absent there? > >> Perhaps the solution, at least for the GTK builds, would be to find the > >> standard icons (more concretely, icon names) that can be used for these > >> buttons > > > AFAIR, last time we made such an effort, we indeed took icons from GTK > > or GNOME or from some similar collection. But that was a long time > > ago, and in particular the two rightmost icons you see in Message mode > > were not part of that set, they were added by someone later. > > It should be enough to change the name of the icons on the toolbar. No need to take icons from GTK (if that means copying files into the Emacs repo). That would only help GTK users. I thought we wanted to improve the Emacs appearance on more than just one toolkit, especially since that toolkit is troubled and many users avoid building with it for that reason.