From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master a539488: Always make a multibyte string for the frame title (bug#42904) Date: Sun, 23 Aug 2020 21:54:14 +0300 Message-ID: <83tuwt6vmx.fsf@gnu.org> References: <20200823171831.19233.37353@vcs0.savannah.gnu.org> <20200823171832.86B3620A10@vcs0.savannah.gnu.org> <87364dfbmo.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12614"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 23 20:54:57 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9v8r-0003BW-0R for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Aug 2020 20:54:57 +0200 Original-Received: from localhost ([::1]:40870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9v8q-0001i4-3c for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Aug 2020 14:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9v8H-000143-Mh for emacs-devel@gnu.org; Sun, 23 Aug 2020 14:54:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56996) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9v8H-0000FI-4k; Sun, 23 Aug 2020 14:54:21 -0400 Original-Received: from [176.228.60.248] (port=2455 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k9v8F-0004zy-VZ; Sun, 23 Aug 2020 14:54:20 -0400 In-Reply-To: <87364dfbmo.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 23 Aug 2020 20:41:35 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254152 Archived-At: > From: Lars Ingebrigtsen > Date: Sun, 23 Aug 2020 20:41:35 +0200 > Cc: Mattias Engdegård > > This is giving me some compilation warnings on Debian: > > xdisp.c: In function ‘gui_consider_frame_title’: > xdisp.c:12571:31: warning: pointer targets in passing argument 1 of ‘str_as_multibyte’ differ in signedness [-Wpointer-sign] > 12571 | len = str_as_multibyte (title, mode_line_noprop_buf_end - title, > | ^~~~~ > | | > | char * > In file included from dispextern.h:25, > from composite.h:29, > from xdisp.c:441: > character.h:226:36: note: expected ‘unsigned char *’ but argument is of type ‘char *’ > 226 | CHAR_STRING (int c, unsigned char *p) > | ~~~~~~~~~~~~~~~^ Silly compiler. Please try again, I hope I fixed this.