From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] icomplete-vertical
Date: Tue, 06 Apr 2021 05:31:15 +0300
Message-ID: <83tuokb0uk.fsf@gnu.org>
References: <dff0cccf05b51da8e080@heytings.org> <87h7kkwcy1.fsf@posteo.net>
 <dff0cccf059a4de2b0f3@heytings.org>
 <CADwFkmneNA91i7v-fqLhuTEqbU0PDA-pkq6hsQZBkHi=b-9pyQ@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="18244"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: gregory@heytings.org, philipk@posteo.net, emacs-devel@gnu.org
To: Stefan Kangas <stefankangas@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 04:32:09 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lTbVh-0004f7-A0
	for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 04:32:09 +0200
Original-Received: from localhost ([::1]:34768 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lTbVg-0008Vy-AM
	for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 22:32:08 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59100)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lTbUw-00084A-VC
 for emacs-devel@gnu.org; Mon, 05 Apr 2021 22:31:22 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42150)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lTbUw-00085o-EQ; Mon, 05 Apr 2021 22:31:22 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3980
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lTbUs-0005r3-VN; Mon, 05 Apr 2021 22:31:19 -0400
In-Reply-To: <CADwFkmneNA91i7v-fqLhuTEqbU0PDA-pkq6hsQZBkHi=b-9pyQ@mail.gmail.com>
 (message from Stefan Kangas on Mon, 5 Apr 2021 18:08:02 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:267454
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/267454>

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 5 Apr 2021 18:08:02 -0700
> Cc: emacs-devel@gnu.org
> 
> Gregory Heytings <gregory@heytings.org> writes:
> 
> >> Why is this a patch that uses advice and hook instead of a user option
> >> that changes the behaviour of icomplete directly?
> >
> > Because it's the simplest / cleanest way to do it.  It's a kind of derived
> > minor mode.
> 
> Advice is not entirely unproblematic though, so the recommendation is
> usually to avoid them in libraries for use by others.  Even more so in
> Emacs itself, I think.
> 
> See the ELisp Manual sections `(elisp) Advising Named Functions' and
> `(elisp) Coding Conventions'.

Indeed, we prefer not to use advice in our own code.