From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master 82ccc3a: ; Mention the previous change in NEWS
Date: Tue, 08 Jun 2021 18:02:08 +0300 [thread overview]
Message-ID: <83tum8e6xb.fsf@gnu.org> (raw)
In-Reply-To: <cbb3b7d5-c976-2a9e-d304-d0d1cd7a441e@yandex.ru> (message from Dmitry Gutov on Tue, 8 Jun 2021 17:46:16 +0300)
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 8 Jun 2021 17:46:16 +0300
>
> >>> *** Commands that use 'grep-find' now follow symlinks by default.
> >>
> >> Not exactly: going by the option's description in the manual, it follows
> >> symlinks for all arguments passed from the command line
> >
> > That's easily fixed, and isn't the main point of my message.
>
> Just helping get the details right.
Sure; thanks.
> >> rgrep, which also has some ignores to handle, uses "." as the DIR
> >> argument, so it should see no change.
> >
> > That's just the default, right?
>
> No, that's what it does: it passes for directory to search in through
> the value of default-directory. The argument to 'find' is always ".".
Not sure I follow: the user could customize grep-find-template to put
a specific directory instead of <D>, right?
> >> xref-matches-in-directory has no known callers anymore, but any
> >> third-party code should see the IGNORES honored better with those old
> >> versions of 'find'.
> >
> > So we could say that any command which uses xref-matches-in-directory
> > is affected.
>
> Is that better than saying that the variable changed? Possibly affecting
> any code that uses it is an obvious implication.
How about saying both?
> We can say that about xref-matches-in-directory, noting that the change
> is likely to only be noticeable with old versions of 'find'.
That'd be good, yes.
> Which apparently includes macOS systems, but I'm not sure which
> ones, and whether using "Homebrew" or not matters for this case.
Maybe also some *BSD? We could mention macOS, or we could say
something like "non-GNU Find".
> Also, we'll probably mark xref-matches-in-directory as obsolete sooner
> or later (xref-matches-in-files is generally a better, more composable
> choice), so I'm not sure how much attention we should bring to it.
We aren't there yet, though.
> > Once again, if nothing's changed, why did you decide to add this
> > entry? I guess you thought it had some importance. I just think we
> > should better explain what have really changed, and doing that in the
> > terms of a not-so-simple value of an option doesn't make that clear.
>
> I figured you wanted to enumerate the exact commands that were affected.
I thought that was possible. If not, let's say what we can.
next prev parent reply other threads:[~2021-06-08 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 16:55 master 82ccc3a: ; Mention the previous change in NEWS Eli Zaretskii
2021-06-08 0:48 ` Dmitry Gutov
2021-06-08 12:16 ` Eli Zaretskii
2021-06-08 14:46 ` Dmitry Gutov
2021-06-08 15:02 ` Eli Zaretskii [this message]
2021-06-08 15:21 ` Dmitry Gutov
2021-06-08 15:44 ` Eli Zaretskii
2021-06-08 15:56 ` Dmitry Gutov
2021-06-10 12:16 ` Eli Zaretskii
2021-06-10 12:26 ` Dmitry Gutov
2021-06-10 14:20 ` Eli Zaretskii
2021-06-10 17:06 ` Dmitry Gutov
2021-06-11 6:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tum8e6xb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).