From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master e37eb7f: Add support for pixel wheel deltas on NS Date: Sat, 27 Nov 2021 13:03:42 +0200 Message-ID: <83tufxzwq9.fsf@gnu.org> References: <20211125030922.2353.1129@vcs0.savannah.gnu.org> <20211125030924.7258E2094B@vcs0.savannah.gnu.org> <871r34h6pi.fsf@gmail.com> <87fsrkzfq1.fsf@yahoo.com> <83tug05whz.fsf@gnu.org> <87tufzycli.fsf@yahoo.com> <837dcv4e79.fsf@gnu.org> <87wnkvflk7.fsf@yahoo.com> <83zgpr2uvr.fsf@gnu.org> <87fsrjfeb1.fsf@yahoo.com> <83r1b32lvr.fsf@gnu.org> <877dcvf8ec.fsf@yahoo.com> <831r323lgs.fsf@gnu.org> <87v90ecvoa.fsf@yahoo.com> <83lf1a1651.fsf@gnu.org> <875ysecd75.fsf@yahoo.com> <83fsri13k0.fsf@gnu.org> <87wnkuax4q.fsf@yahoo.com> <83y259zxgz.fsf@gnu.org> <87sfvhc1hp.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3975"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 27 12:04:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqvV9-0000p5-8q for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 12:04:15 +0100 Original-Received: from localhost ([::1]:44570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqvV6-0000aK-VF for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Nov 2021 06:04:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvUW-0008Je-4Q for emacs-devel@gnu.org; Sat, 27 Nov 2021 06:03:36 -0500 Original-Received: from [2001:470:142:3::e] (port=54772 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvUV-0002XP-Ri; Sat, 27 Nov 2021 06:03:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uy2ITTp6RRU7F+aWZhMRymLS8wRp2VDyIfGXFlFyYVk=; b=lyilX6m/JYzP JCjkZ4L8ol6UWseExZFJzy78gsP+FEEncNgqVi8tyNuxDjRreyyaDCx+ltgTttu0C/5o0bKRpJugf fzknJkyFFYBEU/5FNb9+zpH9i0TVr79DAxzdDsMYFtZi0FKcavQ2Rru5qb1tlVzJJgp+TbxDGlhg/ R6hBLpKGT2zHxBCNawWOH1RLcyRiOc4xQLLgoVa0G146e1lEG6IFdJ/CUVCF2ky6ew3XJAShKhkO9 gb53F1990oST7h/7nbWLLGe3JmT2Oryr/2q9/MT5R9UZleoUcKkVhJL0ukEtlQYCnAFA99a1BDG9w YgQHNXTesxvqYZwfBbPDdw==; Original-Received: from [87.69.77.57] (port=1720 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqvUV-0003Z3-D6; Sat, 27 Nov 2021 06:03:35 -0500 In-Reply-To: <87sfvhc1hp.fsf@yahoo.com> (message from Po Lu on Sat, 27 Nov 2021 18:54:42 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280323 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Sat, 27 Nov 2021 18:54:42 +0800 > > Eli Zaretskii writes: > > > The event may have additional arguments after > > @var{position}. The third argument after @var{position}, if present, > > is a pair of the form @w{@code{(@var{x} . @var{y})}}, where @var{x} > > and @var{y} are the number of pixels to scroll by in each axis. > > > It mentions the 3rd argument (starting from 1, I presume, given the > > format of the event shown in @item). But the code in pixel-scroll.el > > does: > > It says "the third argument after @var{position}", which is the fifth > element (1-based) in the lispy event, as position is the second element > (again, one-based) of the event. > > But I agree that the wording is confusing and can probably be improved > to just mention that the fifth element contains the pixel information. So what are the two arguments between POSITION and (X . Y), the 3rd and the 4th elements in the Lispy event? They should be documented in the general form of the event.