From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Merging the pgtk branch Date: Sun, 05 Dec 2021 16:08:05 +0200 Message-ID: <83tufn2lh6.fsf@gnu.org> References: <835ywpo8ar.fsf@gnu.org> <20210811.001515.1312870178782255892.masm@luna.pink.masm11.me> <20211130.004115.1186997531521134959.masm@luna.pink.masm11.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuuki Harano Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 05 15:09:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtsCK-0007hT-3V for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Dec 2021 15:09:00 +0100 Original-Received: from localhost ([::1]:51368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtsCI-000135-N2 for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Dec 2021 09:08:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtsBY-0000Ln-My for emacs-devel@gnu.org; Sun, 05 Dec 2021 09:08:12 -0500 Original-Received: from [2001:470:142:3::e] (port=40040 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtsBX-0004Do-6D; Sun, 05 Dec 2021 09:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DtZYlhXetoe1Iz7oGy8z9u5MrfdMz8XhUVbhQvyZz4c=; b=MLOa59y9pnKK H85cIGVfOf4+8WlJkrD9T4hAwvJB+QGoBKry2+lh3GxVVm8nFLrnYYgfc5lLNXlwCPkkg8VwBbqcP Z732oRoBIzesCbcfptLYu1Q/+E7xdKglUQm363uep7rnPBy4hEpWV6vp1vYP1K7VpHsU7Clm9/HPJ wyAwHAX6XZG4XHrX/LPu9TN/lRNrAOUH5JQsd2K+nyxMQy55jSS1Rk98pX22q+eQL4ty4a6ybTnmS qt3ZvM6i8oy2yCa33kPywqCwBfZoS4OZqSVYOx0yZUcqWJmGzQmekShBN+3Z+kPuBR4UBzo3CPAfd FK3heAauJIv/5r0Gw4naJA==; Original-Received: from [87.69.77.57] (port=4653 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtsBW-0004vW-4m; Sun, 05 Dec 2021 09:08:11 -0500 In-Reply-To: <20211130.004115.1186997531521134959.masm@luna.pink.masm11.me> (message from Yuuki Harano on Tue, 30 Nov 2021 00:41:15 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281000 Archived-At: > Date: Tue, 30 Nov 2021 00:41:15 +0900 (JST) > Cc: emacs-devel@gnu.org > From: Yuuki Harano > > >>> @@ -4775,10 +4779,17 @@ gui_set_border_width (struct frame *f, Lisp_Object arg, Lisp_Object oldval) > >>> if (border_width == f->border_width) > >>> return; > >> > >>> +#ifndef HAVE_PGTK > >>> if (FRAME_NATIVE_WINDOW (f) != 0) > >>> error ("Cannot change the border width of a frame"); > >>> +#endif > >> > >>> f->border_width = border_width; > >>> + > >>> +#ifdef HAVE_PGTK > >>> + if (FRAME_TERMINAL (f)->frame_rehighlight_hook) > >>> + (*FRAME_TERMINAL (f)->frame_rehighlight_hook) (f); > >>> +#endif > >> > >> Why is the above done only for PGTK? > > > > I'm sorry. I forgot the reason. > > I thought that gui_set_border_width could change the border width of a frame. > But there is the code: > --- > if (FRAME_NATIVE_WINDOW (f) != 0) > error ("Cannot change the border width of a frame"); > --- > I was confused, and added #ifndef around it. > > I don't know about the function. > What is it for? It's for setting the width of the "external border" of the frame, something that window managers generally disallow. Doesn't PGTK define FRAME_NATIVE_WINDOW to return non-zero for any GUI frame? If so, you don't have to #ifdef this, it will work as with any other window-system. Thanks.