From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 3d38d1d: Add sqlite3 support to Emacs Date: Sun, 12 Dec 2021 14:17:02 +0200 Message-ID: <83tufenhkx.fsf@gnu.org> References: <20211211035614.15517.53830@vcs0.savannah.gnu.org> <20211211035616.984DD20A0A@vcs0.savannah.gnu.org> <87ee6j4ty4.fsf@yahoo.com> <8735mz4o70.fsf@yahoo.com> <83k0gbr0dm.fsf@gnu.org> <87y24r33bn.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30648"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, stefankangas@gmail.com, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 12 13:17:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwNnh-0007kx-6D for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Dec 2021 13:17:57 +0100 Original-Received: from localhost ([::1]:59952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwNnf-0005hm-5b for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Dec 2021 07:17:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNn0-00051M-Ry for emacs-devel@gnu.org; Sun, 12 Dec 2021 07:17:14 -0500 Original-Received: from [2001:470:142:3::e] (port=58170 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNmz-0001jQ-Mq; Sun, 12 Dec 2021 07:17:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0o3uYOOcxumrwDjCtL+izj+jOGH8NSlhrttw/Id8lvs=; b=e8f4utFj8CoT YyLArcOICqa0mAV5n6QvPTHMe90EFfN9Bj6YdvAytZ0YKO2XET51cIjxrPbW4kSH638la1U9R7V3t bQgoF0afyZTQAodwi1jh0+99Vgj9viWt+Vck0okZzUwvyj3wxadQP1oDEHokNZe8w1x8b1ZgvVkrv 6gneYvJ/4/Kp6Pi8G53FWF81U/o+t0/LamYRw6ESRGMitewcuMiE2oJd0vnlfxz9OG9jIGDe8sDdw 3vNtGbJAv/aIO5PCArEgQel8SfAPmoE3l/JxjhTILwjf2Um1gOJihxH1e1PR0Ad5wX0ggnEPJexPh UUvkQjhUwEJTK1T52EfPyQ==; Original-Received: from [87.69.77.57] (port=3530 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNmw-0003bQ-8n; Sun, 12 Dec 2021 07:17:10 -0500 In-Reply-To: (message from Richard Stallman on Sat, 11 Dec 2021 22:59:53 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281786 Archived-At: > From: Richard Stallman > Cc: eliz@gnu.org, larsi@gnus.org, stefankangas@gmail.com, > emacs-devel@gnu.org > Date: Sat, 11 Dec 2021 22:59:53 -0500 > > and provides some details: for instance, should the > > symbol be named `plugin_is_GPL_compatible', or something like > > `plugin_is_free_software' (as SQLite3 is public domain instead of under > > the GPL). > > I don't know anything technically about sqlite3, so I can't begin > to think about how to implement this, and I'm not sure what your > suggestions really mean. > > What I do know is this: the crucial question is not what name that > symbol should have, but rather, Which programs need to define it? > Are you proposing to modify the free plug-ins to define this symbol, > and make sqlite3 itself check for it? > > We really should have addressed this _before_ putting sqlite3 into the > Emacs repository at all. The issue of loading extensions is somewhat orthogonal to sqlite3 support itself. Loading of sqlite3 extensions requires an explicit call to an Emacs primitive, it cannot happen automatically. > > It should reuse what gcc does to load its plugins. GCC asks for a such > > symbol to check the plugins are GPLv3-compatible. > > That's a good thing to do, but note that every plugin for GCC was > written specifically for dynamic linking with GCC. The plugin's > developers define ths symbols to be checked. > > If we put the same mechanism into a modified sqlite3 -- let's call it > "GNUish sqlite3" -- we will need to make GNUish modified versions of > the plug-ins as well. No, the idea is that Emacs itself will verify the compatibility before asking sqlite3 to load the extension.