From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X Date: Tue, 11 Jan 2022 15:35:56 +0200 Message-ID: <83tuea75tv.fsf@gnu.org> References: <164181573002.27254.10999604516337949526@vcs2.savannah.gnu.org> <20220110115530.E4B34C0DA1D@vcs2.savannah.gnu.org> <87zgo3pzu3.fsf@yahoo.com> <8335lva3ev.fsf@gnu.org> <87k0f7p0p4.fsf@yahoo.com> <837db68muw.fsf@gnu.org> <896262450.1351717.1641907100144@mail.yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31975"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 11 15:01:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7HiT-00088A-GJ for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 15:01:37 +0100 Original-Received: from localhost ([::1]:50616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7HiS-0004Mh-6e for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jan 2022 09:01:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7HJo-00044O-KO for emacs-devel@gnu.org; Tue, 11 Jan 2022 08:36:12 -0500 Original-Received: from [2001:470:142:3::e] (port=46114 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7HJk-0003LG-MH; Tue, 11 Jan 2022 08:36:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0u4wgNJIMYSNFTIJ87CQ3ASn8ySyfh+hX6KRwj0avMw=; b=LpgjAjnJsEBW IXzgvcfIq0NfPS1Kn75Oay09NEjmHXNUkSBgyBhqWuiAYFmCfMKf1CRWMCEyH80t9lTC/rAxtogDY y5j/0ZdRi4w3QOfXedqL0LvVUbVnRYIjxy98lHzaWbuJ2I/NAjxuasjBUQMuzBWtlY9XPPb3wb6rr vMjQ5OFA3usMll0srgdTsF7KZtu1bf9fmLLqRVeklw7SdyyboxHOmr6ZYUhW/j+QVx59HjZWZFdqn fV1GKy/Smu6nnCyAoTBEXLnkkCeW9Zdh1OAoNErC7fFFa2vCNYfEyS7ZJCHoS2e8xWRjhzPrHRZZ0 mSPfgTn/DJOMqjBHsQRZjw==; Original-Received: from [87.69.77.57] (port=3488 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7HJj-0004Vw-1K; Tue, 11 Jan 2022 08:36:04 -0500 In-Reply-To: <896262450.1351717.1641907100144@mail.yahoo.com> (message from Po Lu on Tue, 11 Jan 2022 13:18:20 +0000 (UTC)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284602 Archived-At: > Date: Tue, 11 Jan 2022 13:18:20 +0000 (UTC) > From: Po Lu > Cc: emacs-devel@gnu.org > > [Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked > and this reaches the list] It did work. > > I have a problem with this correction, because I don't understand the > > need for it. s->width is the width of the glyph string, which is > > computed from the glyphs that comprise the glyph string. Those glyphs > > were laid out by display_line, which should never add a glyph to a > > glyph row if that glyph doesn't fit on the screen. So how come > > s->width in your case was too large? Or maybe it's s->x that was > > wrong (does the underline start exactly under the first glyph)? > > > So I suspect that your fix hides a much more serious problem > > elsewhere. Please investigate the problem you saw before the change. > > Thanks, will do. Should I revert this fix? I don't see a reason to revert immediately, as the change doesn't do any particular harm, being on master. It's up to you.