From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Findirect_function Date: Fri, 14 Jan 2022 14:16:53 +0200 Message-ID: <83tue61phm.fsf@gnu.org> References: <87tue61tz1.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 13:20:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8LYx-0008CU-V4 for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 13:20:12 +0100 Original-Received: from localhost ([::1]:51582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8LYw-0006C4-LQ for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 07:20:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8LVm-00042f-Kg for emacs-devel@gnu.org; Fri, 14 Jan 2022 07:16:54 -0500 Original-Received: from [2001:470:142:3::e] (port=55804 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8LVl-0000BM-Q4; Fri, 14 Jan 2022 07:16:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SpiSKxEtzNkJLTOQrRbGG6CVu4B/Kx2Viwtn4B2GO9U=; b=dN9U/ohPhlHxjo4+wMSc Ns+FNaQZNKw2sA/dhGjBUbWNTuWwTCKH0AGsjXqtf6yT3NQEWS009wunF4NKYq5kHgQBCABZILpC2 O1hT6qFsv0H+R7b68+JkmIs10mlpziTmw9X7F2dvjn1jEkZ1L7ZaQTQfHKPYHBP7O3XLLORVSuJq+ Tqlei3Pe0cSArScq12QWVDLPEQ+mNmxs+vLwHxU1RmRt/v6cWEWlCZbpxl5upbwI1YkKDi9eLB8c5 x5Nhnz9B+DUhVXAGihgqQNDkJOLij8T9DQepEFTsUUZhKEZmEDJ0ZsrR1LjNN2kopM85JQ3EZLdFG uFvOctu2HRva1A==; Original-Received: from [87.69.77.57] (port=1332 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8LVl-0008Tj-Ci; Fri, 14 Jan 2022 07:16:54 -0500 In-Reply-To: <87tue61tz1.fsf@elite.giraud> (message from Manuel Giraud on Fri, 14 Jan 2022 11:40:02 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284744 Archived-At: > From: Manuel Giraud > Date: Fri, 14 Jan 2022 11:40:02 +0100 > > Maybe it is bike shedding territory (and maybe I'm missing something) > but here are two patches for Findirect_function and its usage. "make > check" is the same and so far it works for me™. Do we care about the additional cost a function call? funcall and apply are quite hot spots in Emacs, AFAIK.