From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sat, 12 Feb 2022 21:38:40 +0200 Message-ID: <83tud3ri2n.fsf@gnu.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 12 20:40:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIyFq-0006LB-JE for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 20:40:22 +0100 Original-Received: from localhost ([::1]:33710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIyFn-00039Z-BO for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Feb 2022 14:40:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIyEK-0002TX-0X for emacs-devel@gnu.org; Sat, 12 Feb 2022 14:38:48 -0500 Original-Received: from [2001:470:142:3::e] (port=47712 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIyEI-0004uy-Vp; Sat, 12 Feb 2022 14:38:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HoxYJNTp8GR5N4qZARA3kNlRlVDoqk7HskSypbDc+zI=; b=p6x5OC1maE7U ZMyc6FK1T6iE6clytjvwbTMEuhjMBbPdiBCGjL4wS3LpPzdpOTfyEIfd+7oidjsi47ls/WhG6ucXr PgKdU2xpEydkDtAowdW8Y4fy+lLAh5jdx7e6a+oVidSF7wAG7evJ3ax1f5i0Ivp5Cq2eymRaqy3ZS jLVdFF3MbGP3cnjmsE0JVtqddoYP6TPMYa8+4IM4aqGxGI/A3u0rgJ/daV/qJFgEcjZ2l2Cg+Axdm KZCA4QcI4UDtwwL86ybII+rnNXnaA8YYdU41FnYUSZC5k8+B6Ozl4AuvSVJYuVX/utM/PuPU0nsSO 8dHQ7dj/RKyx2dPLEj+rjg==; Original-Received: from [87.69.77.57] (port=2541 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIyEI-0001Jd-72; Sat, 12 Feb 2022 14:38:46 -0500 In-Reply-To: (message from Stefan Monnier on Sat, 12 Feb 2022 14:15:54 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286192 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org, larsi@gnus.org > Date: Sat, 12 Feb 2022 14:15:54 -0500 > > >> > * lisp/ls-lisp.el (ls-lisp-format, ls-lisp-format-file-size): The > >> > human-readable file sizes can be 7 characters wide (e.g., > >> > "1016.1k") (bug#53937). > >> > >> Why would we want the ".1" in "1016.1k"? > > > > See file-size-human-readable. > > I know. And I'm asking why `file-size-human-readable` gives so > much accuracy. It's a feature: (format (if (and (>= (mod file-size 1.0) 0.05) (< (mod file-size 1.0) 0.95)) "%.1f%s%s" "%.0f%s%s")