unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: larsi@gnus.org, malsburg@posteo.de, emacs-devel@gnu.org
Subject: Re: master 91418d27e9: Add new functions for computing character metrics for windows
Date: Sat, 30 Apr 2022 19:19:35 +0300	[thread overview]
Message-ID: <83tuaa7dd4.fsf@gnu.org> (raw)
In-Reply-To: <jwvee1eefuq.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 30 Apr 2022 11:52:44 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: larsi@gnus.org,  malsburg@posteo.de,  emacs-devel@gnu.org
> Date: Sat, 30 Apr 2022 11:52:44 -0400
> 
> > Emacs is still 85% fixed-pitch.  We still don't "have the technology"
> > to work with variable-pitch fonts as simply and efficiently as with
> > fixed-pitch.  In this situation, lamenting the fact that an API is
> > less helpful with variable-pitch fonts strikes me as a clear case of
> > premature optimization.
> 
> That's not my point.  All I'm saying is that it's just another function
> that does the ~90% work.

Any function that deals with integer columns and lines will never be
able to do a 100% job.  And yet we have quite a few of those, and they
are used all over, with generally good results.

> > No, I didn't.  If someone needs to use text with different faces, then
> > calling this function is a mistake.
> 
> Most of the code that will want to use this function can be confronted
> with text with different faces completely out of its control
> (e.g. because of hi-lock, goto-address-mode, you name it).
> So you're saying that in practice most uses are "a mistake".

That's not the use case this function supports.  It supports the use
case where some Lisp program produces text under its control, and
wants to know how much of the text can be put on a single screen line.

> > I cannot disagree more.  The function has a place and serves a class
> > of use cases well enough to be justified.  It prevents Lisp programs
> > from using low-level interfaces like font-get-glyphs etc., on the one
> > hand, and OTOH is simpler and faster than window-text-pixel-size.
> 
> I'm not arguing against the new functionality.
> I'm arguing against the way it's exposed.

The way it's exposed reflects the needs of the use cases it serves.



  reply	other threads:[~2022-04-30 16:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165123811050.20687.5215165731843845332@vcs2.savannah.gnu.org>
     [not found] ` <20220429131511.9BD62C01683@vcs2.savannah.gnu.org>
2022-04-29 13:46   ` master 91418d27e9: Add new functions for computing character metrics for windows Stefan Monnier
2022-04-29 13:53     ` Lars Ingebrigtsen
2022-04-29 14:55       ` Stefan Monnier
2022-04-29 19:59         ` Eli Zaretskii
2022-04-29 20:40           ` Stefan Monnier
2022-04-30  5:23             ` Eli Zaretskii
2022-04-30 11:12             ` Lars Ingebrigtsen
2022-04-30 13:33               ` Stefan Monnier
2022-04-30 13:48                 ` Eli Zaretskii
2022-04-30 14:34                   ` Stefan Monnier
2022-04-30 15:25                     ` Eli Zaretskii
2022-04-30 15:52                       ` Stefan Monnier
2022-04-30 16:19                         ` Eli Zaretskii [this message]
2022-04-30 21:47                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tuaa7dd4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=malsburg@posteo.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).