unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [Patch] Two typos captured by clang on OpenBSD
@ 2022-06-21 14:59 Manuel Giraud
  2022-06-21 15:48 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Manuel Giraud @ 2022-06-21 14:59 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]

Hi,

There is no functional in this patch. It just muffles 2 warnings.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Two-typos-captured-on-OpenBSD-clang.patch --]
[-- Type: text/x-patch, Size: 1474 bytes --]

From 906ead58895ddbf2e5c6656fe63f776cdc055ced Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Tue, 21 Jun 2022 16:52:52 +0200
Subject: [PATCH] Two typos captured on OpenBSD/clang

; * src/kqueue.c (kqueue_compare_dir_list): Indent typo.
; * src/sysdep.c (system_process_attributes): Unused variable on OpenBSD.
---
 src/kqueue.c | 4 ++--
 src/sysdep.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/kqueue.c b/src/kqueue.c
index c3c4631784..99a9434cc2 100644
--- a/src/kqueue.c
+++ b/src/kqueue.c
@@ -159,8 +159,8 @@ kqueue_compare_dir_list (Lisp_Object watch_object)
 	    (watch_object, Fcons (Qwrite, Qnil), XCAR (XCDR (old_entry)), Qnil);
 	/* Status change time has been changed, the file attributes
 	   have changed.  */
-	  if (NILP (Fequal (Fnth (make_fixnum (3), old_entry),
-			    Fnth (make_fixnum (3), new_entry))))
+	if (NILP (Fequal (Fnth (make_fixnum (3), old_entry),
+			  Fnth (make_fixnum (3), new_entry))))
 	  kqueue_generate_event
 	    (watch_object, Fcons (Qattrib, Qnil),
 	     XCAR (XCDR (old_entry)), Qnil);
diff --git a/src/sysdep.c b/src/sysdep.c
index 95295e7e67..28ab8189c3 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -3869,7 +3869,7 @@ system_process_attributes (Lisp_Object pid)
 Lisp_Object
 system_process_attributes (Lisp_Object pid)
 {
-  int proc_id, nentries, fscale, i;
+  int proc_id, fscale, i;
   int pagesize = getpagesize ();
   int mib[6];
   size_t len;
-- 
2.36.1


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] Two typos captured by clang on OpenBSD
  2022-06-21 14:59 [Patch] Two typos captured by clang on OpenBSD Manuel Giraud
@ 2022-06-21 15:48 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2022-06-21 15:48 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: emacs-devel

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Date: Tue, 21 Jun 2022 16:59:43 +0200
> 
> There is no functional in this patch. It just muffles 2 warnings.

Thanks, installed.

In the future, please send this to bug-gnu-emacs@gnu.org.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-21 15:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 14:59 [Patch] Two typos captured by clang on OpenBSD Manuel Giraud
2022-06-21 15:48 ` Eli Zaretskii

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).