From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Thu, 01 Sep 2022 14:57:30 +0300 Message-ID: <83tu5rqpcl.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <87sflc91q7.fsf@gnus.org> <87wnao7l74.fsf@gnus.org> <0d5679a1-7635-53db-51c7-0ac0e35325d8@yandex.ru> <87mtbke7wf.fsf@gnus.org> <87ilm8e5am.fsf@gnus.org> <87k06nz9g8.fsf@gnus.org> <874jxrz5ai.fsf@gnus.org> <4f7fa9ba-2a85-3bc6-8f4f-bf59ee6598ca@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, juri@linkov.net, luangruo@yahoo.com, ams@gnu.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 01 14:33:20 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTjNn-0008t6-R6 for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 14:33:20 +0200 Original-Received: from localhost ([::1]:44504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTjNm-0000TZ-Ox for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 08:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTion-0007aA-HO for emacs-devel@gnu.org; Thu, 01 Sep 2022 07:57:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTiol-0002pt-U3; Thu, 01 Sep 2022 07:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j6OQV2ZpF3uh1IPKQiRgySwZrERvvSswIjv0j50+mqs=; b=Wu3ZTeayfpSU VhX+OhscxPeOwQ8a/rlXzam3YEuTDW5EUWcNlc5awnu36EkjyCCkKVbOL9FjWpNXkuX3iLeByZ9D9 9jQT69y11oBjBpqje5InqLUjWR2s5FowokWRxVOMPj5srXH5DaDmltwDglZ6zI31VPygVoJ8I7fCe BDgOcOLWGF7Z2OQ2pk6JJEIzXK3pSZzZFP4IvdHCnVsKF3DmcsFkwv1Unv7me6MZQAFmI9kqoVyWZ 6Vt6a+rGXuJmbqlNIieFmJY+BabVfdVM7U+ZKZ8t+F2cK6xrAfqv59il5U5OI/07WmeeMd9R+tCqN JGOAgJhB27hBLROZ+Z10mw==; Original-Received: from [87.69.77.57] (port=2036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTioi-0002Gu-Dr; Thu, 01 Sep 2022 07:57:04 -0400 In-Reply-To: <4f7fa9ba-2a85-3bc6-8f4f-bf59ee6598ca@yandex.ru> (message from Dmitry Gutov on Thu, 1 Sep 2022 14:48:32 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294478 Archived-At: > Date: Thu, 1 Sep 2022 14:48:32 +0300 > Cc: Juri Linkov , Po Lu , > "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org > From: Dmitry Gutov > > On 01.09.2022 14:45, Lars Ingebrigtsen wrote: > > Oh, I was assuming that we were assuming that we had "patch" installed > > for this to work. I don't think that's unreasonable for new > > functionality like this. > > I suggested this upthread but didn't get any affirmative response. > > This would be easier, yes. If it will be easier, by all means go for it. I, too, don't think it's unreasonable. Even on MS-Windows, there's a port of GNU Patch, and people who have Git for Windows installed get Patch as part of the deal. Thanks.