unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Testing font things
Date: Mon, 21 Nov 2022 16:12:51 +0200	[thread overview]
Message-ID: <83tu2s2y70.fsf@gnu.org> (raw)
In-Reply-To: <jwvy1s4zb2h.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Mon, 21 Nov 2022 08:42:01 -0500)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 21 Nov 2022 08:42:01 -0500
> 
> I'm trying to write a test for our font choice code (bug#59347)

Is it useful?  This test will work only on your platform and maybe on a few
other lucky ones.  The list of fonts installed on any given system is
unpredictable.

I suggest to defer coding of the test until we fully understand the problem,
and then try to write the test in some generic way independent of specific
font families.

That said...

>       (ert-deftest font-tests--bug59347 ()
>         (skip-unless (and font-tests--misc-fixed font-tests--dejavu-sans))
>         (face-spec-set
>          'default
>          '((t :font "-misc-fixed-*-*-semicondensed-*-13-*-*-*-*-*-*-*")))
>         (face-spec-set 'font-tests-dejavu '((t :family "DejaVu Sans")))
>         (with-temp-buffer
>           (let ((w (frame-root-window font-tests--gui-frame)))
>             (set-window-buffer w (current-buffer))
>             (insert "hello " (propertize "world" 'face 'font-tests-dejavu))
>             (should (member (font-at (1+ (point-min)) w)
>                             font-tests--misc-fixed))
>             (should (member (font-at (1- (point-max)) w)
>                             font-tests--dejavu-sans)))))
> 
>   But this fails because `fonts-at` gets me a "font-object" whereas
>   `list-fonts` gets me "font entities".  How can I convert one to
>   the other?

...why do you need to go to these obscure entities, when you have the font's
name as a string to begin with?  So you should be able to:

  . use face-font, which returns the font's name as a string
  . compare that string with what you wanted it to be
  . and/or use find-font to check whether the font is in fact installed on
    the system

If the above is not enough, what is missing?



  reply	other threads:[~2022-11-21 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 13:42 Testing font things Stefan Monnier
2022-11-21 14:12 ` Eli Zaretskii [this message]
2022-11-30  3:31   ` Stefan Monnier
2022-11-30  5:06     ` Stefan Kangas
2022-11-30 13:36     ` Eli Zaretskii
2022-11-22  0:24 ` Po Lu
2022-11-30  3:48   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tu2s2y70.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).