From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: fweimer@redhat.com, larsi@gnus.org, emacs-devel@gnu.org, ding@gnus.org
Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently
Date: Mon, 19 Dec 2022 19:58:25 +0200 [thread overview]
Message-ID: <83tu1rcm2m.fsf@gnu.org> (raw)
In-Reply-To: <87k02ns2sg.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Mon, 19 Dec 2022 09:48:15 -0800)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: Florian Weimer <fweimer@redhat.com>, larsi@gnus.org,
> emacs-devel@gnu.org, ding@gnus.org
> Date: Mon, 19 Dec 2022 09:48:15 -0800
>
> On 12/19/22 19:07 PM, Eli Zaretskii wrote:
> >> Going back to older mail, I see that previously the From: header was
> >> written in encoded form to .overview (slightly wrapped to avoid SMTP
> >> issues):
> >>
> >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec'
> >> 'hello3.spec.' -> 'hello3.spec'
> >> =?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?=
> >> <elfutils-devel@sourceware.org> Thu, 24 Nov 2022 16:27:56 +0800
> >> <CAE2XoE_RBNdsPZMLiSQKJroyx4ycvqf7y+VDbuY=-XbhOwsL8g@mail.gmail.com>
> >> <20220920084307.1696-1-luoyonggang@gmail.com>
> >> <20220920084307.1696-2-luoyonggang@gmail.com>
> >> <Y0nH98k6YumMRSz0@wildebeest.org>
> >> <CAE2XoE-xfFQNMN1JYSi8Kp+-DUUookRkzwUV+OvKGfnZKDXKEA@mail.gmail.com>
> >> <20221019194930.GC24703@redhat.com>
> >> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org>
> >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org>
> >> 705 32 Xref: oldenburg.str.redhat.com
> >> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler"
> >> <fche@redhat.com>, elfutils-devel@sourceware.org To: Mark Wielaard
> >> <aegon@wildebeest.org>
> >>
> >> Now it uses unencoded form:
> >>
> >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows 罗
> >> 勇刚(Yonggang Luo) via Elfutils-devel
> >> <elfutils-devel@sourceware.org> Mon, 19 Dec 2022 20:32:48 +0800
> >> <CAE2XoE-Xv6+4Npj38ih_nPMZ8e6ph7oS8wxvKFx1uE-sRfH_kw@mail.gmail.com>
> >> <20221217165213.152-1-luoyonggang@gmail.com>
> >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref:
> >> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To:
> >> elfutils-devel@sourceware.org
> >
> > Is that a problem? I think this was part of the reason for that
> > change in nnml.el.
>
> It would definitely be a problem to change the on-disk representation of
> data in the .overview files! Lots of code depends on a very specific
> format for those files; I've broken things badly in the past by removing
> header encoding there.
But this change is there since Emacs 28, so if it's a problem, someone
would have hollered already, no?
Or are you saying that the changes I installed are causing the
difference? If so, I don't see how that could happen, since the
change just ignores any errors signaled by rfc2047, and if rfc2047
does signal an error, what is stored in the file is the same string as
what we did before the new function nnml--encode-headers was added and
we started using it.
So unless I'm missing something, the changes I installed cannot cause
any new problems we didn't have since quite long ago.
next prev parent reply other threads:[~2022-12-19 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210122180801.14756.84264@vcs0.savannah.gnu.org>
[not found] ` <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org>
2022-12-16 22:42 ` master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Florian Weimer
2022-12-17 7:45 ` Eli Zaretskii
2022-12-17 14:57 ` Florian Weimer
2022-12-17 15:52 ` Eli Zaretskii
2022-12-19 13:59 ` Florian Weimer
2022-12-19 17:07 ` Eli Zaretskii
2022-12-19 17:27 ` Florian Weimer
2022-12-19 17:44 ` Eli Zaretskii
2022-12-19 17:48 ` Eric Abrahamsen
2022-12-19 17:58 ` Eli Zaretskii [this message]
2022-12-19 18:05 ` Eric Abrahamsen
2022-12-19 18:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tu1rcm2m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=fweimer@redhat.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).