From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Regression in dump-emacs-portable Date: Sat, 18 Feb 2023 09:07:09 +0200 Message-ID: <83ttzjzc2q.fsf@gnu.org> References: <83ttzocomk.fsf@gnu.org> <834jrncd6a.fsf@gnu.org> <83r0up39qe.fsf@gnu.org> <83bkls1hzn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 18 08:08:07 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTHKI-0006FK-S9 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Feb 2023 08:08:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTHJN-0004yB-AK; Sat, 18 Feb 2023 02:07:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTHJL-0004y0-TT for emacs-devel@gnu.org; Sat, 18 Feb 2023 02:07:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTHJL-0005V1-KM; Sat, 18 Feb 2023 02:07:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gvyNAEPjhjg5UXl97xPkt5iY/83FfpLTrVw2WZ3Uhbw=; b=eIqLAxRUv9RI uO6keaYh9a3rrxBcKfK/Ja98k7ZfVlWknDdjlDFI/GQD/Z44yaiflYoUsCE7lUxh06N54ZSgW3F6I Mbr8sIZEsePXCUuuZawza50wQhYW/qdfPrKNGLqwbAr9qQe+7Pfz0Lqnnx64/rM/o4MojSYAuSMdI 0vsX2daY0HFRCCDK6kPd9dNRVWqIxDz9MFc4q9RnuvJZ1TtTXPmyQsGC6WuJmi1c6u92gCsC9Ekii QwNfRXvIiGC00r1d8nymVer723BYAgdm0MdfEDielMRANjlzkvRX0MgFT1g9pc2UCBWrOLpu/sCWG T6ahK6/ckLx3x0JDO/X3fg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTHJL-0004N1-0t; Sat, 18 Feb 2023 02:07:07 -0500 In-Reply-To: (message from Lynn Winebarger on Fri, 17 Feb 2023 18:44:18 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303519 Archived-At: > From: Lynn Winebarger > Date: Fri, 17 Feb 2023 18:44:18 -0500 > Cc: emacs-devel@gnu.org > > On Fri, Feb 17, 2023 at 9:31 AM Eli Zaretskii wrote: > > I don't understand what will this solve. Why does it matter when > > exactly is a variable initialized, if in any case that will happen > > before re-dumping? > > You're right with respect to the current definitions of > custom-initialize-* functions that will only set variables if they are > unbound. > The docstring for custom-initialize-delay is: > "Delay initialization of SYMBOL to the next Emacs start. > This is used in files that are preloaded (or for autoloaded > variables), so that the initialization is done in the run-time > context rather than the build-time context. This also has the > side-effect that the (delayed) initialization is performed with > the :set function." > But "so the initialization is done in the run-time context" and "to > the *next* Emacs start" (emphasis mine) are contradictory unless > dumping can only happen once. The first sentence should be "Ensure > SYMBOL is set to initial-value at Emacs startup". temacs and bootstrap-emacs (and in general any Emacs that is about to dump itself) also start up, so the change you propose will make the doc string less accurate. > I'll take a shot at a more thorough rewrite of the customization > system to properly support redumping this weekend and send another > patch. I'm not sure this is the tree we should be barking up. The problem is more general than just delayed-initialization of some defcustoms.