From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] change dired--find-possibly-alternative-file behaviour. Date: Sun, 26 Feb 2023 07:26:06 +0200 Message-ID: <83ttz9j8up.fsf@gnu.org> References: <87mt51o5bu.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21378"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Felix Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 26 06:26:25 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pW9YH-0005P9-1S for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Feb 2023 06:26:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pW9Xx-0002bF-Mr; Sun, 26 Feb 2023 00:26:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW9Xv-0002ax-MB for emacs-devel@gnu.org; Sun, 26 Feb 2023 00:26:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW9Xv-0003Ae-Da; Sun, 26 Feb 2023 00:26:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LM5hXNUSdYGwz5vNYQcepiGpeWyldc2AwFZ2AcxOJM8=; b=lqKC3DNr6P54 Sm+dNw8ZWv9wqlr26sKi8udfX8Nvyokn2io/CgexEYVGXXWU0+e9UiSfe7dy19x8rmMvARXcLSB6O HcW4WSMFhwcQyp2rMk/AUIajOsRCE+kiTgAHiVN72lKHqa66YchaRBLgy6eOwsCTll1pXyRl/o9oy a5Ba+/MA3/8RB6kpOcnXOTukJX6LPtEGT58v+m/zx/JV2gMYOCVB9kVj0s/w1Br5yiNwkXi6vQZC6 cIJ0xHtSSrPOyRX35Q82DFbsjkCXLQkdQetv0UGo5dJFPHgKwnaUFtT5SdrIVrm03kIFYLXyfD+0J lrlqyl2XGM/EeJgAKuA4Og==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW9Xu-0003gb-0K; Sun, 26 Feb 2023 00:26:03 -0500 In-Reply-To: <87mt51o5bu.fsf@web.de> (message from Felix on Sat, 25 Feb 2023 20:43:57 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303810 Archived-At: > From: Felix > Date: Sat, 25 Feb 2023 20:43:57 +0100 > > diff --git a/lisp/dired.el b/lisp/dired.el > index 76499d0f520..620508bef4f 100644 > --- a/lisp/dired.el > +++ b/lisp/dired.el > @@ -2728,7 +2728,8 @@ dired-find-file > (defun dired--find-possibly-alternative-file (file) > "Find FILE, but respect `dired-kill-when-opening-new-dired-buffer'." > (if (and dired-kill-when-opening-new-dired-buffer > - (file-directory-p file)) > + (file-directory-p file) > + (= (length (get-buffer-window-list)) 1)) > (progn > (set-buffer-modified-p nil) > (dired--find-file #'find-alternate-file file)) What if get-buffer-window-list returns nil?