From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org, thievol@posteo.net
Subject: Re: [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p
Date: Thu, 14 Sep 2023 16:13:22 +0300 [thread overview]
Message-ID: <83ttrwlwy5.fsf@gnu.org> (raw)
In-Reply-To: <87wmwsoqe0.fsf@posteo.net> (message from Philip Kaludercic on Thu, 14 Sep 2023 13:06:47 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: emacs-devel@gnu.org, thievol@posteo.net
> Date: Thu, 14 Sep 2023 13:06:47 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I think this change is simply incorrect: the first argument of
> > string-suffix-p is not interpreted as a regexp, but as a simple
> > literal string (the implementation uses compare-strings internally).
>
> But why is it incorrect? `string-suffix-p' is passed a string, while
> `string-match-p' takes a regular expression, that might be too liberal
> but should still match everything the previous check did -- or am I
> missing something?
Why do the change when string-suffix-p already ensures there's nothing
in the second argument after the suffix?
next prev parent reply other threads:[~2023-09-14 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169468919249.10884.8856179202519044902@vcs2.savannah.gnu.org>
[not found] ` <20230914105954.20BD1C051D0@vcs2.savannah.gnu.org>
2023-09-14 12:25 ` [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p Philip Kaludercic
2023-09-14 12:59 ` Eli Zaretskii
2023-09-14 13:06 ` Philip Kaludercic
2023-09-14 13:13 ` Eli Zaretskii [this message]
2023-09-14 16:21 ` Philip Kaludercic
2023-09-14 18:49 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttrwlwy5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).