From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice
 when ls-lisp is loaded.
Date: Thu, 07 Dec 2023 08:19:58 +0200
Message-ID: <83ttou3569.fsf@gnu.org>
References: <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org>
 <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org>
 <jwvy1e8i6o4.fsf-monnier+emacs@gnu.org> <83plzj4jfk.fsf@gnu.org>
 <jwvbkb3ia6t.fsf-monnier+emacs@gnu.org> <8334wf45v3.fsf@gnu.org>
 <jwvv89bggvx.fsf-monnier+emacs@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21706"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org, luangruo@yahoo.com
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 07 07:20:50 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1rB7kf-0005WK-Rl
	for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Dec 2023 07:20:49 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1rB7ji-0003PF-3j; Thu, 07 Dec 2023 01:19:50 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1rB7jh-0003P7-2Y
 for emacs-devel@gnu.org; Thu, 07 Dec 2023 01:19:49 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rB7jf-0001ay-D2; Thu, 07 Dec 2023 01:19:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=LriFUib0a8vFJjBGl4iqNwnBPqxeFbnZU+l18mrma68=; b=XGh5tL7cYuBo
 oAyVSMl1yiSX5WKlxG97MF+hUd+Ibby8nZC3xl6mKcH0XrpWJ2F0mgLTenDZyL+qnNoVlA13kZbtf
 7hnrKb0RjCKj8nszWkEYIKdaG/wNPRatXZrjMhOk1uzaKquEsijO8I7NDd+ZuOsRMSyi1+Jb5wioM
 3MVe90iNTuYw56llcyCsfbf8KE6An+PBm6z34bsC/wCyhIrdUEcsS5N8o3+jUgFoCzn/7P/S+exXD
 bWNYvL274+g/OkF3rm3Frpk++KD8rQ9sbam5eWdZgDIVlhlY5CgfsF/MD5E+lcI+LrheC6zPInUAl
 lJfmWBIJQDTypJJlsXoKNg==;
In-Reply-To: <jwvv89bggvx.fsf-monnier+emacs@gnu.org> (message from Stefan
 Monnier on Wed, 06 Dec 2023 16:32:51 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:313580
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/313580>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org,  luangruo@yahoo.com
> Date: Wed, 06 Dec 2023 16:32:51 -0500
> 
> But I guess I didn't realize back then that `ls-lisp.el` is preloaded in
> W32 builds

We also need to support users on non-w32 platforms who load ls-lisp as
part of their customizations or interactively.  So the solution cannot
be limited to when ls-lisp is preloaded.