From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: attribute warn_unused_result Date: Sun, 06 Feb 2011 06:07:01 +0200 Message-ID: <83sjw1957e.fsf@gnu.org> References: <83r5bobz2k.fsf@gnu.org> <4D4B4EEA.50907@cs.ucla.edu> <83hbckb3u4.fsf@gnu.org> <83zkqbah6c.fsf@gnu.org> <4D4C95B8.6010001@cs.ucla.edu> <4D4DFAB9.10609@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1296965224 21633 80.91.229.12 (6 Feb 2011 04:07:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 6 Feb 2011 04:07:04 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 06 05:06:59 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Plvtr-0001qR-Fv for ged-emacs-devel@m.gmane.org; Sun, 06 Feb 2011 05:06:59 +0100 Original-Received: from localhost ([127.0.0.1]:38866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Plvtq-0002Ew-RH for ged-emacs-devel@m.gmane.org; Sat, 05 Feb 2011 23:06:58 -0500 Original-Received: from [140.186.70.92] (port=56212 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Plvtm-0002Em-Ce for emacs-devel@gnu.org; Sat, 05 Feb 2011 23:06:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Plvtl-000508-E9 for emacs-devel@gnu.org; Sat, 05 Feb 2011 23:06:54 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:34440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Plvtl-000504-5Q for emacs-devel@gnu.org; Sat, 05 Feb 2011 23:06:53 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LG600900GLZLK00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sun, 06 Feb 2011 06:06:52 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.97.124]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LG6009L8GREKQ10@a-mtaout22.012.net.il>; Sun, 06 Feb 2011 06:06:52 +0200 (IST) In-reply-to: <4D4DFAB9.10609@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135631 Archived-At: > Date: Sat, 05 Feb 2011 17:34:49 -0800 > From: Paul Eggert > Cc: emacs-devel@gnu.org > > On 02/05/2011 08:35 AM, Chong Yidong wrote: > > If you fix this, please fix it in the emacs-23 branch (assuming the bug > > exists there), so that it will be included in the 23.3 release. > > I could do that, but three things. First, I've never installed > into the emacs-23 branch and am a bit worried about messing with that > if it is about to be released. With bzr, each branch is in its own directory, preferably under the shared repository (i.e., under the same parent as the trunk directory and your feature branch). The same command "bzr branch" that you issued to clone the trunk will work for the branch, except that the URL is different: bzr+ssh://eliz@bzr.savannah.gnu.org/emacs/emacs-23/ > Second, I just now installed a fix for mainline platforms into the > trunk (see below) but don't know how to fix similar problems on > Windows, DOS, or NextStep. MS-DOS uses GCC, so it will work with lib/ignore-value.h. MS-Windows already works with lib/ignore-value.h (your change in sysdep.c already used it). So there's no need to use #ifndef DOS_NT in this case.