unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: esr@thyrsus.com
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: The fixes-bug field
Date: Fri, 17 Jan 2014 09:32:43 +0200	[thread overview]
Message-ID: <83sisn12sk.fsf@gnu.org> (raw)
In-Reply-To: <20140116214714.GA19493@thyrsus.com>

> Date: Thu, 16 Jan 2014 16:47:14 -0500
> From: "Eric S. Raymond" <esr@thyrsus.com>
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org>:
> > I think we need to figure out these details and more or less agree on
> > them, before converting the repository (if needed).  The worst thing
> > that can happen is to invest all that effort, only to find out later
> > that adding more "fixes bug NNN" commits don't work well, or that
> > there's a much more easy/elegant way of doing that.
> 
> You guys figure out what policy you want.  I'll either implement it 
> or (less likely) explain why I can't.

I don't know enough about git to make useful suggestions, sorry.

I also don't quite understand what you mean by "policy".  With my
understanding of "policy", I thought that part was already clear: we
want a committer to be able to say "this changeset is related to bug
#XYZZY", and have that info recorded in the history in a way that
would later support queries of the type "which commit(s) are related
to bug #12345?"

(Note that I say "related to" because "fixes" might be inaccurate: we
sometimes commit changes that fix only parts of a bug, or even make
the bug easier to catch.  We also sometimes revert incorrect
bugfixes.)

If this information will be in the commit message (one suggestion so
far, AFAIU), we should define its precise format and location within
the commit message.  We should also try to find a convenient way of
specifying the bug number from the 'git commit' command line.  If git
supports some extensibility features, we should either find or write
an extension for that.  If no such features are available at this
time, we could ask git developers to provide one for this purpose,
like we asked the bzr developers to develop the changelog_merge plugin
that avoids merge conflicts in ChangeLog files.

Similar issues arise with other possible implementations, like git
notes or maybe tags.

The above is my take on the "policy" part; comments are welcome.  But
what I hoped to see and didn't is discussion of git features that
could be used for this functionality and comparison of their relative
merits and demerits.  I don't see how we can make a decision on that
without some research in this area, and I hoped that git experts
around here will provide their knowledge and expertise to help us make
that decision.  Instead, I see a lot of discussions about the
technique of converting the bugfix information, which is IMO
premature, as long as we didn't decide how to store it in git and how
to specify it at commit time.



  reply	other threads:[~2014-01-17  7:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 14:13 The fixes-bug field Eric S. Raymond
2014-01-16 16:13 ` Stefan Monnier
2014-01-16 16:30   ` Eric S. Raymond
2014-01-16 16:55     ` Eli Zaretskii
2014-01-16 17:54       ` Glenn Morris
2014-01-16 18:09         ` Eric S. Raymond
2014-01-16 18:38         ` Darren Hoo
2014-01-16 19:32           ` Stefan Monnier
2014-01-16 20:06             ` Glenn Morris
2014-01-16 21:30               ` Eli Zaretskii
2014-01-16 21:24           ` Eli Zaretskii
2014-01-16 18:55         ` Paul Eggert
2014-01-16 19:13           ` Glenn Morris
2014-01-16 20:25             ` Paul Eggert
2014-01-16 18:08       ` Eric S. Raymond
2014-01-16 18:36         ` Eli Zaretskii
2014-01-16 20:04           ` Eric S. Raymond
2014-01-16 21:29             ` Eli Zaretskii
2014-01-16 21:47               ` Eric S. Raymond
2014-01-17  7:32                 ` Eli Zaretskii [this message]
2014-01-17  7:58                   ` Paul Eggert
2014-01-17  8:04                     ` Jarek Czekalski
2014-01-17  9:21                       ` Yuri Khan
2014-01-17 14:31                     ` Stefan Monnier
2014-01-17 15:57                       ` Lars Ingebrigtsen
2014-01-17 16:12                         ` Stefan Monnier
2014-01-17 17:20                           ` Lars Ingebrigtsen
2014-01-18  9:19                         ` Jarek Czekalski
2014-01-18 16:02                           ` Lars Ingebrigtsen
2014-01-17 13:16                   ` Eric S. Raymond
2014-01-17 13:55                     ` Eli Zaretskii
2014-01-17 14:26                   ` Stefan Monnier
2014-01-16 17:00     ` Glenn Morris
2014-01-16 17:22     ` Achim Gratz
2014-01-16 17:57       ` Glenn Morris
  -- strict thread matches above, loose matches on Subject: below --
2014-01-16 14:15 Eric S. Raymond
2014-01-16 17:11 ` Eli Zaretskii
2014-01-17 20:29   ` Eric S. Raymond
2014-01-18  7:51     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sisn12sk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=esr@thyrsus.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).