From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Your commit 7409a79 Date: Sat, 06 Dec 2014 20:54:08 +0200 Message-ID: <83sigszk1b.fsf@gnu.org> References: <83h9x917il.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1417892084 11375 80.91.229.3 (6 Dec 2014 18:54:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Dec 2014 18:54:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tom Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 06 19:54:34 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XxKUy-0000qQ-Qa for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 19:54:32 +0100 Original-Received: from localhost ([::1]:55263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxKUy-0005iA-G3 for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 13:54:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxKUq-0005h3-1B for emacs-devel@gnu.org; Sat, 06 Dec 2014 13:54:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XxKUk-0005EI-3V for emacs-devel@gnu.org; Sat, 06 Dec 2014 13:54:23 -0500 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:53408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxKUj-0005ED-Rn for emacs-devel@gnu.org; Sat, 06 Dec 2014 13:54:18 -0500 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NG600L00C2RAB00@mtaout25.012.net.il> for emacs-devel@gnu.org; Sat, 06 Dec 2014 20:49:59 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NG600IKXCBB8Y30@mtaout25.012.net.il>; Sat, 06 Dec 2014 20:49:59 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179203 Archived-At: > From: Tom > Date: Sat, 6 Dec 2014 16:14:42 +0000 (UTC) > > Eli Zaretskii gnu.org> writes: > > > > Please always start the commit log summary line with a capital letter, > > and end the sentence with a period. (Actually, in the above > > particular case the summary line is redundant and could be omitted -- > > but this is a stylistic comment, not a requirement.) > > > > Also, renaming a file needs an entry in the target's ChangeLog, like > > this: > > > > * CONTRIBUTE: Renamed from etc/CONTRIBUTE. > > > > and it also should end with a period, not a comma. > > > > These are exactly the situations where a server side commit hook > is really useful for the following reasons: The intent of my message was to explain how to prepare good log messages that will not trigger any hook which will reject the commit. Apart of having more people follow the standards to begin with, avoiding such rejection is a Good Thing because while one fixed a rejected push, someone else could push and force you to pull/rebase. IOW, don't overestimate automated hooks and don't underestimate the value of education.