From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: EWOULDBLOCK and EINPROGRESS in process.c Date: Tue, 24 Mar 2015 20:09:19 +0200 Message-ID: <83sicup8s0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1427220607 17569 80.91.229.3 (24 Mar 2015 18:10:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Mar 2015 18:10:07 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 24 19:09:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YaTH0-000166-0G for ged-emacs-devel@m.gmane.org; Tue, 24 Mar 2015 19:09:54 +0100 Original-Received: from localhost ([::1]:33797 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaTGy-0000uo-7C for ged-emacs-devel@m.gmane.org; Tue, 24 Mar 2015 14:09:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaTGi-0000uY-Ft for emacs-devel@gnu.org; Tue, 24 Mar 2015 14:09:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaTGd-0007kD-Hx for emacs-devel@gnu.org; Tue, 24 Mar 2015 14:09:36 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:53391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaTGd-0007jh-9y for emacs-devel@gnu.org; Tue, 24 Mar 2015 14:09:31 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NLQ00G00A0TXI00@mtaout28.012.net.il> for emacs-devel@gnu.org; Tue, 24 Mar 2015 20:08:07 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLQ00FIZADJXO20@mtaout28.012.net.il> for emacs-devel@gnu.org; Tue, 24 Mar 2015 20:08:07 +0200 (IST) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184172 Archived-At: process.c has this fragment after it calls 'connect': #ifdef NON_BLOCKING_CONNECT #ifdef EINPROGRESS if (is_non_blocking_client && xerrno == EINPROGRESS) break; #else <<<<<<<<<<<<<<<<<<<<<<<<<<<< #ifdef EWOULDBLOCK if (is_non_blocking_client && xerrno == EWOULDBLOCK) break; #endif #endif #endif Can someone tell why we need that "#else" there? Suppose there's a platform that has both values defined, but only returns EWOULDBLOCK when a non-blocking 'connect' is called -- that platform will fall through the cracks here. Is there any problem to replace #else with #endif here?